You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 28c6cf1
Browse filesBrowse the repository at this point in the historyBrowse files
fix(runner): tell an empty fill point from a blind one before the tap
The pre-tap lookup returned nil for both, so one refusal carried two
claims. coordinateTapTextInputIdentityAt now answers input, absent, or
unavailable; absent refuses with NO_TEXT_INPUT_AT_POINT and unavailable
refuses with TEXT_INPUT_PROBE_UNAVAILABLE, both before the focus tap.
The hint and docs name every route that reaches the guard, including
ref, selector and replay fills, whose aim point is the centre of the
rect they resolved.
Fixes#1721
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -3,6 +3,7 @@
3
3
## Unreleased
4
4
5
5
- Add `settings mobile-data on|off` for adb-backed Android targets. It switches mobile data through `svc data` and reports the `mobileData` state stored in the global `mobile_data` row; multi-SIM read-back is not covered yet. Every other target refuses it before anything runs, and `--app` is refused because the switch is device-wide.
6
+
- On iOS, a `fill` that runs under a degraded XCTest snapshot channel now aims at a point, including ref, selector and replay fills. When the runner identifies no text input under that point, it refuses with `NO_TEXT_INPUT_AT_POINT` (`error.details.reason: no_text_input_at_point`, `dispatched: no`) before dispatching its focus tap, and no field changes; when the input lookup itself cannot answer, it refuses with `TEXT_INPUT_PROBE_UNAVAILABLE` (`error.details.reason: text_input_probe_unavailable`). Previously such a fill cleared and typed through the app-level first responder, so it could rewrite a field the caller never named, or report a clear failure after emptying it. A ref or selector fill whose rect centre misses the real field (an outer container, a non-input node) now needs a point inside the input's own rect.
6
7
- Limrun iOS snapshots no longer fail when the instance reports a numeric or boolean accessibility value (the system photo picker's tabs report `1`/`0`): the provider seam normalizes variant scalars to text, the way the Apple tree does. Limrun nodes now also publish `selected: true` for nodes carrying the `Selected` trait, so snapshot output and `selected:` selectors can tell a picked photo from an unpicked one.
7
8
-`settings` refuses a setting the target does not serve before anything changes, with `UNSUPPORTED_OPERATION`, `settings <setting> is not supported on this device`, and the target's `error.details.reason` (such as `unsupported-platform-leaf`). This replaces the macOS `INVALID_ARGS` refusal and the Apple `setting-unsupported-on-leaf` reason, and now also covers settings that used to reach the device first, such as Android `reset-keychain` or Apple `animations`.
8
9
-`settings` refuses, before touching the device, a state its setting does not accept (`Invalid <setting> state: …`), a permission action or mode its target does not take (such as `permission deny accessibility`), and a stray extra argument (such as `clear-app-state <app> <extra>`). The CLI and the daemon accept the same state spellings, in any casing or surrounding whitespace.
message:"no text input identified at the provided coordinates",
169
-
hint:"A coordinate fill replaces the text of the input under the point, so the point must sit inside one. Run snapshot -i, then fill the field by ref or selector, or aim at a point inside its rect. The runner also reports this when its input lookup cannot answer, so re-run snapshot before concluding the point is empty."
174
+
hint:"A fill replaces the text of the input under its point, so the point must sit inside one — for a ref or selector fill, that point is the centre of the rect it resolved to, which an outer container or a non-input node does not give you. Run snapshot -i, pick the input node itself, and aim at a point inside its rect."
175
+
)
176
+
)
177
+
}
178
+
179
+
/// The refusal of a coordinate `fill` whose point the input lookup could not read, answered before
180
+
/// the focus tap so nothing runs. The channel is degraded, so the runner cannot tell whether an
181
+
/// input is there; typing would reach the app-level first responder, which is what #1721 refuses.
message:"the runner could not read the text input at the provided coordinates",
188
+
hint:"The accessibility lookup for the point could not answer on the degraded channel, so the runner dispatched nothing and no field changed — this does not mean the point has no input. Retry the fill, or run snapshot -i and fill the input node by ref once its capture reads back."
Copy file name to clipboardExpand all lines: apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/UnitTests/RunnerTests+CoordinateTextEntryTests.swift
+20Lines changed: 20 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -2,6 +2,26 @@ import XCTest
2
2
3
3
extensionRunnerTests{
4
4
#if AGENT_DEVICE_RUNNER_UNIT_TESTS&& os(iOS)
5
+
/// The input the coordinate probe finds at the point, failing the test when it finds none or
6
+
/// cannot answer. A fixture that does not expose its own field is a broken lane, not a refusal.
Copy file name to clipboardExpand all lines: apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/UnitTests/RunnerTests+SynthesizedTextEntryTests.swift
Copy file name to clipboardExpand all lines: contracts/fixtures/dispatch-disclosure.json
+6Lines changed: 6 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -199,6 +199,12 @@
199
199
"trigger": "structured runner reply with code NO_TEXT_INPUT_AT_POINT: a coordinate fill refused before its focus tap because the runner identified no text input under the point",
"trigger": "structured runner reply with code TEXT_INPUT_PROBE_UNAVAILABLE: a coordinate fill refused before its focus tap because the pre-tap input lookup could not answer",
0 commit comments