|
1 | 1 | import assert from 'node:assert/strict'; |
2 | 2 | import { test } from 'vitest'; |
3 | 3 | import { |
| 4 | + describeReplayGestureArityError, |
4 | 5 | gesturePayloadFromPositionals, |
5 | 6 | gesturePayloadToPositionals, |
6 | 7 | normalizePublicGesture, |
@@ -57,6 +58,86 @@ test('gesture recording codec round-trips fling with distance', () => { |
57 | 58 | assert.deepEqual(gesturePayloadFromPositionals(gesturePayloadToPositionals(payload)), payload); |
58 | 59 | }); |
59 | 60 |
|
| 61 | +test('a retired trailing positional reports its migration, not a bare usage line', () => { |
| 62 | + assert.throws(() => swipePayloadFromPositionals(['197', '650', '197', '300', '300']), { |
| 63 | + code: 'INVALID_ARGS', |
| 64 | + message: |
| 65 | + 'swipe accepts 4 arguments: x1 y1 x2 y2. The trailing durationMs positional was removed: use "gesture pan 197 650 0 -350 300" for the same timed drag, or "swipe 197 650 197 300" for a default-duration swipe.', |
| 66 | + }); |
| 67 | + assert.throws(() => gesturePayloadFromPositionals(['fling', 'down', '100', '200', '80', '500']), { |
| 68 | + code: 'INVALID_ARGS', |
| 69 | + message: /trailing durationMs positional was removed: use "gesture fling down 100 200 80"/, |
| 70 | + }); |
| 71 | + assert.throws(() => gesturePayloadFromPositionals(['swipe', 'left', '500']), { |
| 72 | + code: 'INVALID_ARGS', |
| 73 | + message: /trailing durationMs positional was removed: use "gesture swipe left"/, |
| 74 | + }); |
| 75 | + assert.throws(() => gesturePayloadFromPositionals(['rotate', '35', '100', '200', '800']), { |
| 76 | + code: 'INVALID_ARGS', |
| 77 | + message: /trailing velocity positional was removed: use "gesture rotate 35 100 200"/, |
| 78 | + }); |
| 79 | +}); |
| 80 | + |
| 81 | +test('a malformed line is a usage error rather than a migration claim', () => { |
| 82 | + assert.throws(() => swipePayloadFromPositionals(['1', '2', '3', '4', '5', '6']), { |
| 83 | + code: 'INVALID_ARGS', |
| 84 | + message: 'swipe accepts 4 arguments: x1 y1 x2 y2.', |
| 85 | + }); |
| 86 | + assert.throws(() => swipePayloadFromPositionals(['1', '2', '3', '4', '--unknown']), { |
| 87 | + code: 'INVALID_ARGS', |
| 88 | + message: 'swipe accepts 4 arguments: x1 y1 x2 y2.', |
| 89 | + }); |
| 90 | + assert.throws(() => swipePayloadFromPositionals(['1', '2', '3', '4', 'hello']), { |
| 91 | + code: 'INVALID_ARGS', |
| 92 | + message: 'swipe accepts 4 arguments: x1 y1 x2 y2.', |
| 93 | + }); |
| 94 | +}); |
| 95 | + |
| 96 | +test('the .ad preflight names the offending line and leaves live syntax alone', () => { |
| 97 | + assert.equal( |
| 98 | + describeReplayGestureArityError('swipe', ['197', '650', '197', '300', '300'], 'line 6'), |
| 99 | + 'swipe accepts 4 arguments: x1 y1 x2 y2 (line 6). The trailing durationMs positional was removed: use "gesture pan 197 650 0 -350 300" for the same timed drag, or "swipe 197 650 197 300" for a default-duration swipe.', |
| 100 | + ); |
| 101 | + assert.equal( |
| 102 | + describeReplayGestureArityError('gesture', ['pan', '110', '443', '48', '0', '500'], 'line 2'), |
| 103 | + undefined, |
| 104 | + ); |
| 105 | + assert.equal(describeReplayGestureArityError('click', ['120', '240'], 'line 2'), undefined); |
| 106 | +}); |
| 107 | + |
| 108 | +test('a variable-backed retired positional still gets the migration', () => { |
| 109 | + assert.equal( |
| 110 | + describeReplayGestureArityError('swipe', ['197', '650', '197', '300', '${DURATION}'], 'line 6'), |
| 111 | + 'swipe accepts 4 arguments: x1 y1 x2 y2 (line 6). The trailing durationMs positional was removed: use "gesture pan 197 650 0 -350 ${DURATION}" for the same timed drag, or "swipe 197 650 197 300" for a default-duration swipe.', |
| 112 | + ); |
| 113 | + assert.equal( |
| 114 | + describeReplayGestureArityError( |
| 115 | + 'swipe', |
| 116 | + ['${X1}', '${Y1}', '${X2}', '${Y2}', '${DURATION}'], |
| 117 | + 'line 6', |
| 118 | + ), |
| 119 | + 'swipe accepts 4 arguments: x1 y1 x2 y2 (line 6). The trailing durationMs positional was removed: use "gesture pan x1 y1 dx dy durationMs" for the same timed drag, or "swipe ${X1} ${Y1} ${X2} ${Y2}" for a default-duration swipe.', |
| 120 | + ); |
| 121 | + assert.match( |
| 122 | + describeReplayGestureArityError('gesture', ['rotate', '35', '195', '443', '${V}'], 'line 4') ?? |
| 123 | + '', |
| 124 | + /trailing velocity positional was removed: use "gesture rotate 35 195 443"/, |
| 125 | + ); |
| 126 | +}); |
| 127 | + |
| 128 | +test('the .ad preflight defers to dispatch for values it cannot know yet', () => { |
| 129 | + // `${VAR}` tokens resolve after planning, and interpolation never splits a |
| 130 | + // token, so only the argument count is decidable at parse time. |
| 131 | + assert.equal( |
| 132 | + describeReplayGestureArityError('swipe', ['${X1}', '${Y1}', '${X2}', '${Y2}'], 'line 3'), |
| 133 | + undefined, |
| 134 | + ); |
| 135 | + assert.equal( |
| 136 | + describeReplayGestureArityError('gesture', ['${KIND}', '1', '2', '3'], 'line 4'), |
| 137 | + undefined, |
| 138 | + ); |
| 139 | +}); |
| 140 | + |
60 | 141 | test('pinch and rotate syntax rejects a partial origin', () => { |
61 | 142 | assert.throws(() => gesturePayloadFromPositionals(['pinch', '1.5', '100']), { |
62 | 143 | code: 'INVALID_ARGS', |
|
0 commit comments