You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1fc9169
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(daemon): consolidate session-script test factories and drop saveScriptDefaultedHealedPath (#1508)
Preparatory slice for P4a (#1478). No aggregate, no transaction type, no
publication-writer migration — those land separately.
Two things:
1. Name the session-script session states in the shared test factories
(`makeAuthoringSession`, `makeRepairArmedSession`,
`makeRepairCompleteSession`) and route 40 inline session literals across
11 test files through them. The `saveScript*` fields are not independent
— recording without a boundary is ordinary authoring, a boundary without
`saveScriptComplete` is an ARMED-but-uncommittable repair, and only the
COMPLETE combination publishes — so re-deriving the combination per test
buried the distinction each test was actually about. Pure refactor: the
factories write today's fields and no assertion was weakened.
2. Delete `saveScriptDefaultedHealedPath`. It had zero production readers:
the writer's refuse-on-exist guard has been uniform since #1235, so the
flag was written in three places and never consulted. Removing it takes
its R7 owner row with it and lowers the R10 baseline from 30/42 to 29/40
(the ratchet fails on a drop too, so this cannot be deferred).
Claude-Session: https://claude.ai/code/session_01RXQLYV7etZx3gcXsUsrQJ8
Co-authored-by: Claude <[email protected]>
@@ -135,11 +145,10 @@ test('deterministic errors (INVALID_ARGS) are returned with the default shape
135
145
// `error.retriable ?? retriableForErrorCode(error.code)` fallback is caught.
136
146
test('BLOCKER 2 (second follow-up): a repair-close platform-close failure surfaces retriable:true and diagnosticId/logPath/details at the TOP level through the router',async()=>{
test('#1391: an ordinary close-time script-save failure surfaces details.reason/path and retriable:false through the router, and the session is torn down',async()=>{
0 commit comments