Repository navigation
Commit 19af3bf
committed
fix(action-button): keep the recorded-failure conversion on the press
`isLifecycle` does two things: it skips the app-activation preflight, and it
exempts the command from turning a recorded XCTest issue into
`XCTEST_RECORDED_FAILURE`. The press joined the lifecycle group for the first
and silently took the second, which matters most here because the press declares
no settle and no post-action observation, so that conversion was the only
evidence it landed.
The press now classifies like `home` and skips activation through
`shouldSkipAppActivationPreflight`, where `.alert` already exempts itself for
the same reason. `pressActionButton` also refuses below iOS 16 instead of
pressing a control that API cannot express there, and two Swift tests pin both
decisions where they are decided.1 parent 7f36e4d commit 19af3bf
3 files changed
Lines changed: 50 additions & 11 deletions
File tree
- apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
521 | 521 | | |
522 | 522 | | |
523 | 523 | | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
524 | 541 | | |
525 | 542 | | |
526 | 543 | | |
| |||
610 | 627 | | |
611 | 628 | | |
612 | 629 | | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
613 | 641 | | |
614 | 642 | | |
615 | 643 | | |
| |||
2552 | 2580 | | |
2553 | 2581 | | |
2554 | 2582 | | |
| 2583 | + | |
| 2584 | + | |
| 2585 | + | |
| 2586 | + | |
| 2587 | + | |
| 2588 | + | |
| 2589 | + | |
| 2590 | + | |
2555 | 2591 | | |
2556 | 2592 | | |
2557 | 2593 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
132 | | - | |
| 131 | + | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
137 | | - | |
138 | | - | |
| 136 | + | |
| 137 | + | |
139 | 138 | | |
140 | 139 | | |
141 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
| 98 | + | |
103 | 99 | | |
104 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| |||
0 commit comments