You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 14eafc4
Browse filesBrowse the repository at this point in the historyBrowse files
fix(fill): redact a replayed fill's error and accept textStdin false in batch
- A same-session replay runs its fill through the replay-scoped invoker,
which registers the sensitive value but returned the fill's error as
is. It now redacts that error like handleRequest does, so the replay
message carries the fill's placeholder.
- The daemon batch validator refuses only textStdin: true, matching the
CLI guard; false is the ordinary argv path.
- The error path uses the success path's parameterizeSensitiveString for
values and keys, so a whitespace-only value collapses the string.
- Docs: limit the redaction guarantee to value-bearing fields.
`fill --text-stdin` reads the text from stdin instead of a text argument, so a secret never appears in the CLI's process arguments. Pipe the value with `printf %s`, which sends it verbatim. It reads at most 64 KiB, removes exactly one trailing newline (`\n` or `\r\n`), and refuses a terminal, empty input, invalid UTF-8, or an additional text argument. The value is registered as sensitive for diagnostics, and command output, error messages included, shows it as `${VAR}` with `--record-as` and as `[REDACTED]` otherwise. While script recording is armed, combine it with `--record-as <VAR>` to publish `${VAR}`, or `--no-record` to leave the step out; passing neither is an error. Without an armed recording the step is not recorded. Batch steps do not accept it.
468
+
`fill --text-stdin` reads the text from stdin instead of a text argument, so a secret never appears in the CLI's process arguments. Pipe the value with `printf %s`, which sends it verbatim. It reads at most 64 KiB, removes exactly one trailing newline (`\n` or `\r\n`), and refuses a terminal, empty input, invalid UTF-8, or an additional text argument. The value is registered as sensitive for diagnostics, and command outputshows it as `${VAR}` with `--record-as` and as `[REDACTED]` otherwise, in success data and in an error's message, hint, cause and details; daemon-owned fields such as `logPath` and `diagnosticId` are left unchanged. While script recording is armed, combine it with `--record-as <VAR>` to publish `${VAR}`, or `--no-record` to leave the step out; passing neither is an error. Without an armed recording the step is not recorded. Batch steps do not accept it.
469
469
A successful `click` or `press` means the action was sent to the target where the command found it, whether that is a tap, a mouse click, or an accessibility action. It does not confirm that the action reached that element or changed the screen. When your next step depends on it, add `--verify` to learn whether the screen changed (`changedFromBefore`), add `--settle` to get the diff once the UI goes quiet, or follow with `wait <selector>`for the screen you expect.
470
470
When an interaction fails, see [Retry after a failed command](#retry-after-a-failed-command) before you retry.
471
471
`type` accepts text only. Do not pass `@ref` to `type`; use `fill @ref "text"` to target a field directly, or `press @ref`then`type "text"` to append in the focused field.
0 commit comments