Repository navigation
Commit 14361ae
committed
ci(coverage): fail a PR whose touched functions score CRAP 30 or more
The PR step ran the verdict with `continue-on-error`, so a function over
the threshold only annotated the diff. It now gates the job: the score
itself, or a report that cannot answer the question, is red. The `main`
step keeps `continue-on-error`, because that report is the whole-repo
backlog `main` carries on purpose, and both keep needing `run-coverage`
to have succeeded — without a coverage map there is no verdict to
report, only the coverage step's own red.
CONTRIBUTING.md gains how to read a failure, since a PR now stops on two
different reasons: debt a touched function owes, and a stale coverage
run that has to be re-run. The end-to-end cases drive the real entrypoint
against a real git repo and real fallow, which is the only way to prove
rename-aware attribution and the map cross-check agree with the model.
Closes #34261 parent 8203d7f commit 14361ae
4 files changed
Lines changed: 370 additions & 23 deletions
File tree
- .github/workflows
- docs/agents
- scripts/coverage-crap
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
343 | 344 | | |
344 | | - | |
345 | 345 | | |
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
352 | | - | |
| 352 | + | |
| 353 | + | |
353 | 354 | | |
354 | 355 | | |
355 | 356 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
236 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
237 | 238 | | |
238 | 239 | | |
239 | 240 | | |
| |||
242 | 243 | | |
243 | 244 | | |
244 | 245 | | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
245 | 257 | | |
246 | 258 | | |
247 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
0 commit comments