You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 127db94
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(apple-runner): keep the session module under the size line after the fence (#3220)
The shutdown-detach mechanism moves to runner-adoption.ts beside the
adoption it hands off to; the session module keeps only the map side
of a detach. Pure move: the lifecycle tests that covered the old copy
cover the wrapper unchanged.
// Graceful daemon shutdown hands a request-proven runner off to the next daemon instead of paying
823
-
// the xcodebuild ramp again: the lease token is rewritten to a detached form (so this daemon's own
824
-
// teardown paths no longer classify it as owned), this process gives up its sides of the runner's
825
-
// log, and the session simply leaves the in-memory map. Once this process exits the lease is stale
826
-
// and the adoption path picks it up. Explicit cleanup still works: clean:daemon kills by the lease's
827
-
// runnerPid, and the runner's XCTWaiter self-expires after 24h.
828
-
//
829
-
// Every gate that keeps a session on the kill path is named and reported, because a handoff that
830
-
// silently declines is indistinguishable from a rebuild: the handoff lanes
831
-
// (`resolveRunnerHandoffTarget`), a session that never served a command, still owes a response, or
832
-
// last reported main-thread work still draining (`resolveRunnerDetachDecision`), a missing or
833
-
// unwritable lease, and a runner this process cannot prove alive. What stays in the map is torn down by `stopAllIosRunnerSessions`, which the daemon's
834
-
// shutdown runs right after this — so a shutdown during a startup tears that runner down rather than
835
-
// handing off one that never reached its listener (#2681).
820
+
// The detach decision itself lives in runner-adoption.ts beside the adoption it hands off to
821
+
// (#2681); this is the map side: a detached session leaves the registry and drops its idle
822
+
// timer (the detached module gives up the log observation and marks the session stopped).
0 commit comments