Skip to content

Commit 122c67c

Browse files
committed
fix(#2682): serialize the iOS fixture smoke files on one simulator
`node --test` gives each file its own process and runs them concurrently, and the iOS Smoke job drives all of these files against the one simulator the job booted. Adding the activation lane made that contention visible: the fixture lane died at "cold launch fixture" while the activation lane never saw a disclosure, because each lane was relaunching and closing under the other. One device per job means one file at a time.
1 parent 58f5634 commit 122c67c

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/workflows/ios.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ jobs:
289289
AGENT_DEVICE_IOS_UDID: ${{ steps.ios-simulator.outputs.simulator-udid }}
290290
run: |
291291
pnpm gate build
292-
node --experimental-strip-types scripts/node-test-tmpdir.ts --test test/integration/smoke-ios-simulator-coverage.test.ts test/integration/smoke-ios-simulator.test.ts test/integration/smoke-ios-target-activation.test.ts
292+
node --experimental-strip-types scripts/node-test-tmpdir.ts --test --test-concurrency=1 test/integration/smoke-ios-simulator-coverage.test.ts test/integration/smoke-ios-simulator.test.ts test/integration/smoke-ios-target-activation.test.ts
293293
294294
# #1584: isolated, cheap automatic guard for the #1562 class of regression (iOS silently
295295
# ignoring a `gesture pan` duration). Split out of gesture-lab.ad, which stays full-tier

‎.github/workflows/replays-manual.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ jobs:
170170
AGENT_DEVICE_IOS_UDID: ${{ steps.ios-simulator.outputs.simulator-udid }}
171171
run: |
172172
pnpm gate build
173-
node --experimental-strip-types scripts/node-test-tmpdir.ts --test test/integration/smoke-ios-simulator-coverage.test.ts test/integration/smoke-ios-simulator.test.ts test/integration/smoke-ios-target-activation.test.ts
173+
node --experimental-strip-types scripts/node-test-tmpdir.ts --test --test-concurrency=1 test/integration/smoke-ios-simulator-coverage.test.ts test/integration/smoke-ios-simulator.test.ts test/integration/smoke-ios-target-activation.test.ts
174174
175175
- name: Run iOS physical device replay suite
176176
if: env.IOS_UDID != ''

0 commit comments

Comments
 (0)