Skip to content

Commit 0ae929c

Browse files
committed
refactor(ios): give each snapshot capture step its penalty authority
EffectiveSnapshotCapturePlan carried a backend array, the channel state, a tree-slice budget override, and a pin in parallel. Whether the first step was the periodic probe was inferred from position, and the penalty recorder accepted a channel state defaulted to .normal, so a caller that ran a bounded recovery attempt but forgot its state could re-arm the penalty it was recovering from - the #3896 bug class, still reachable at the interface. A factory-built SnapshotCaptureStep now carries the backend together with its execution mode. captureWithBackend returns the attempt carrying that step; the recorder takes the attempt plus the warmup exemption and no other policy arguments. Only an ordinary attempt has an arming branch; only an accepted completed bounded recovery can clear the penalty early. Plan shapes, the selection-cause slots from #3916, the in-band claim after the occupied skip, and SnapshotXCTestChannelPenalty as the sole expiry owner are unchanged. The channel policy and its verdict helpers move to a named policy file.
1 parent ed798f9 commit 0ae929c

6 files changed

Lines changed: 530 additions & 404 deletions

0 commit comments

Comments
 (0)