You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 093341a
Browse filesBrowse the repository at this point in the historyBrowse files
test(repo-guards): fail when an ADR cites a missing repository file (#4336)
* test(repo-guards): fail when an ADR cites a missing repository file
Closes the last #4205 completion condition. The guard checks every
backticked repository path and bare test file name in docs/adr against
the tracked tree, and skips device paths, globs and runtime state names.
Also fixes the follow-ups from the slimming reviews: ADR 0005's stale
test name, ADR 0012's linkSync rule with --force/--overwrite, ADR 0019's
test-IME startup gap, ADR 0024's perf-capture status, and the
platform-plugin contract comment that credited ADR 0009.
* test(repo-guards): cover Markdown, plist and + paths in the ADR citation guard
Address review: scan .md and .plist citations and paths with +, state
the guard's exact scope in FORMAT.md, qualify ADR 0012's in-place
overwrite rule with --force, and keep perf capture's missing
failed-finish test listed in ADR 0024.
* test(repo-guards): give the ADR citation guard an owner in selection
ci.yml ignores docs paths and the selector treated an ADR as docs-only, so
a PR that added a stale citation got no signal. Add the adr-citations gate,
select it for docs/adr/NNNN-*.md, and run it in docs.yml.
Scan every token in a backticked span so a path inside a longer span is
checked, and inline the single-use tracked-file listing.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* test(repo-guards): extract the ADR citation token scan
Keep findStaleAdrCitations under the complexity gate.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* docs(adr): state exactly what the citation guard checks
Co-Authored-By: Claude Opus 5.5 <[email protected]>
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>
Copy file name to clipboardExpand all lines: docs/adr/0012-interactive-replay.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -152,8 +152,8 @@ Seven normative rules govern it:
152
152
Every teardown commits if and only if the state is `COMPLETE`.
153
153
Before `COMPLETE`, teardown publishes nothing, and idle-reap or shutdown leaves a `REPAIR_SESSION_EXPIRED` tombstone.
154
154
An armed replay skips a terminal source `close` and marks the transaction `COMPLETE`.
155
-
Publication writes `<original-stem>.healed.ad` beside the original unless the caller names a path. The original is never overwritten in place.
156
-
One exclusive `linkSync` publishes the file and refuses every pre-existing target, for repair and ordinary `--save-script` recording alike.
155
+
Publication writes `<original-stem>.healed.ad` beside the original unless the caller names a path. The original is never overwritten in place unless the caller names it as the target with `--force`/`--overwrite`.
156
+
Without `--force`/`--overwrite`, one exclusive `linkSync` publishes the file and refuses a pre-existing target, for repair and ordinary `--save-script` recording alike; with the flag, publication replaces the target atomically.
157
157
158
158
Inside an armed repair segment, out-of-band observation-only commands are excluded from the healed script by default.
Copy file name to clipboardExpand all lines: docs/adr/0019-request-bound-platform-runtime.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -220,7 +220,7 @@ Startup recovery is triggered only by persisted durable manifests or platform-ow
220
220
Daemon shutdown first detaches helper managers for handoff, then stops each still-owned generation at most once after session resources finalize.
221
221
Each domain owns its isolated session-teardown step; there is no generic lifecycle-hook API.
222
222
Test-IME restoration is durable device state with marker recovery; helper stops follow platform policy; close-time cleanup uses neutral owner services.
223
-
Android test-IME marker and web browser orphan startup recovery still need to move to the evidence-triggered pattern when their owning domains migrate.
223
+
Android test-IME marker recovery already runs only on recovery evidence; web browser orphan startup cleanup still needs to move to the evidence-triggered pattern when its owning domain migrates.
224
224
225
225
### 11. The platform-services port carries host asks that bind no device
Copy file name to clipboardExpand all lines: docs/adr/0024-screen-recording-provable-signal.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ Proposed (2026-09-14).
6
6
This ADR amends ADR 0019 section 5 and the capture-kit recovery contracts for the `screen-recording` resource kind only.
7
7
ADR 0019 receives a short pointer paragraph, which section 2.7 of this ADR describes.
8
8
ADR 0022 and ADR 0023 have the same relationship to ADR 0019.
9
-
App-log, audio-probe, and perf-capture keep the ADR 0019 contract unchanged.
9
+
App-log and audio-probekeep the ADR 0019 contract unchanged; perf capture already preserves retry material after a failed finish.
10
10
The shared mechanism of rule 6 reaches each of these kinds only through the own failed-finish test of that kind.
11
11
12
12
Completed rollout history is in git history.
@@ -70,7 +70,7 @@ Six rules make the table operational:
70
70
Forced cleanup is never inferred from "finish threw".
71
71
The mechanism is in the shared coordinator (`packages/capture-kit/src/durable-capture/transitions.ts`).
72
72
But each kind must earn its scope.
73
-
Each of app-log, audio-probe, and perf-capture gets its own failed-finish test that proves what its retry needs.
73
+
Each of app-log and audio-probegets its own failed-finish test that proves what its retry needs; perf capture already has one (`session-capture-binding.test.ts`).
74
74
A kind whose retry needs nothing keeps its current disposal explicitly.
75
75
The Android data loss alone establishes the rule for recording only.
76
76
@@ -322,7 +322,7 @@ This kind would remove the `cleanup-pending` phase and admission ledger.
322
322
It would record the recorder observation and native-path disposition beside the committed export.
323
323
A manifest would remain archived by fence generation until both are settled.
324
324
For each durable kind, failed finish would no longer imply forced cleanup once its failed-finish test states its retry requirements.
325
-
App-log, audio-probe, and perf-capture would retain the ADR 0019 contract unchanged.*
325
+
App-logand audio-probe would retain the ADR 0019 contract unchanged.*
Fallow agrees with custom on value/type classification for every pair but has no dynamic kind.
67
67
Its boundary check follows `export type *` barrels to the declaring module.
68
-
`src/commands/cli-runner.ts → src/agent-device-client.ts` therefore counts as `commands → client`. This adds one more R6 finding.
68
+
The edge from `src/commands/cli-runner.ts` to the retired src/agent-device-client.ts therefore counts as `commands → client`. This adds one more R6 finding.
69
69
Clean-tree findings are custom 0, depcruise 10, and fallow 11.
70
70
Depcruise's ten are three R6 survivors and seven recorded R78 edges.
Copy file name to clipboardExpand all lines: docs/adr/FORMAT.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -44,7 +44,7 @@ Do not repeat general repo guidance that `AGENTS.md` already gives.
44
44
45
45
## The record stays current
46
46
47
-
An ADR states the current truth. It is not a log of the discussion around the decision. An optional dated "Decision history" line records a real change of direction. If the direction really changed, you may add one such line with its reason and a link.
47
+
An ADR states the current truth. It is not a log of the discussion around the decision. A repo guard checks each backticked token with an extension that `test/repo-guards/adr-citations.test.ts` lists. A token that contains `/` must be a tracked path. A bare test file name must be the name of a tracked file. The guard skips absolute paths, home paths, globs, and other bare file names. To name a retired path, write the path in prose without backticks. An optional dated "Decision history" line records a real change of direction. If the direction really changed, you may add one such line with its reason and a link.
0 commit comments