You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 081264a
Browse filesBrowse the repository at this point in the historyBrowse files
fix(daemon): answer the named-session refusal with its own reason at every seam
Round-2 review found #3674's refusal reaching some callers as an untyped
event. `get`/`is` answered a missing session with the generic "no active
session" error before the provenance guard could run; `record start` let
its app-scope INVALID_ARGS refusal win over a session that was gone
altogether; `appstate` carried no typed details and refused requests
that had also stated a concrete device. The refusal details now have one
producer, `namedSessionNotFoundDetails` beside its sibling builders, that
the guard's AppError and `appstate`'s platform-aware response both build
from; each seam orders the guard before its own missing-session refusal;
`appstate` preserves a request naming an identity selector, matching the
resolution guard. The guard module's function-scoped import is confined
to the missing-session branch it can fire on: that keeps the eager-
closure gate at parity and removes a first-time transform cost from the
held-session wait path, which under coverage instrumentation alone
overran `wait-runtime.test.ts`'s fake-timer budget at the unconditional
form (3/3 deterministic failures restored, 3/3 passes at this form).
`namesSessionExplicitly` now accepts the generic flag-record shape the
batch runner carries, fixing the TS2345 the batch call site raised.
@@ -18,14 +18,15 @@ export function namedSessionNotFoundError(sessionAddress: string): AppError {
18
18
returnnewAppError(
19
19
'SESSION_NOT_FOUND',
20
20
`No active session "${sessionAddress}". Run agent-device open <app> --session ${sessionArg} first, or omit --session to run against a device selector.`,
21
+
// One producer for the refusal shape: the reason, dispatched marker, and session address come
22
+
// from the kernel builder every named-session seam shares (#3674); only this site's message
23
+
// adds the open/omit guidance and the session-list hint.
0 commit comments