You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0683a3d
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(ios-runner): name the runner session xctestrun as a process-identity contract
A runner launch is killed by matching `xcodebuild`'s argv with `pkill -f`, and
that argv carries the per-session xctestrun's filename. The filename is
therefore a process-identity contract, but it was spelled three times: inline in
the session, inline in disposal, and again in the daemon-client timeout sweep.
Disposal escaped the device id for regex without flattening it the way the
writer's filesystem sanitization does, so a device id needing flattening built a
cleanup pattern that could not match the file the writer had already written.
Name it once. `runner-artifact-env.ts` now owns the stem, the suffix field
order, the sanitization, and the `pkill -f` pattern derived from those same
parts, and the writer, the session, and disposal all go through it. The name
lives in the writer rather than a shared contracts module because the timeout
sweep must not follow a rename: it ships separately, cannot know which version
named a timed-out launch, and has to keep matching the names older writers used.
So the sweep keeps a pinned literal, and its test proves those bytes still
select both the owner-token and the pre-owner-token spelling. Placing the name
in the module the Apple façades already evaluate also holds the eager-closure
budget (#1960) at zero new edges.
Verified byte-for-byte against the previous patterns for concrete, host-style,
and flattened device ids. The only divergence is the flattened case, where the
old pattern failed to match its own file.
Also record three tooling constraints read from `xcodebuild(1)` and `simctl
help`, and checked on Xcode 27.1: only `TEST_RUNNER_`-prefixed names cross into
the test runner; `simctl launch --stdout/--stderr` resolve their paths inside
the device's data container, so `--console-pty` is the console mode this host
path can use; and xcodebuild re-synthesizes the attachment-lifetime keys from
its own defaults, since a plan setting `keepNever` still builds an xctestrun
carrying `SystemAttachmentLifetime=deleteOnSuccess`.
test('http timeout: pkill cleanup still runs for an undeclared platform (unknown-session case) that terminates nothing, and the hint stays platform-neutral',async()=>{
0 commit comments