Repository navigation
Commit 0192348
authored
fix(ios): parse the Xcode 27 <tagged-backtrace> time-profile stack (#2889)
* fix(ios): parse the Xcode 27 <tagged-backtrace> time-profile stack
Xcode 27 renamed the time-profile stack element and its engineering-type to
tagged-backtrace while keeping the same frame children and id/ref reuse. The
parser matched only <backtrace>, so every row of an Xcode 27 export resolved no
stack, and writeAppleXctracePerfReport failed a trace holding tens of thousands
of samples with "Apple xctrace CPU report contained no samples". Read either
spelling through one name set so id/ref resolution, the innermost-frame rule,
and the report shape stay exactly as they were for older exports.
The fixture is a verbatim 22-row prefix of an xctrace 27.1 (27A9269) export: 19
stack definitions, 2 rows naming their stack through a tagged-backtrace ref, 4
innermost frames and 3 innermost binaries reached through refs, and one row
whose stack column is a sentinel. The multi-run test now carries a cross-run
frame ref because a real append-run export numbers ids with one counter across
its runs.
Closes #2860
* chore(gates): own .xml package captures in the affected selector
The package-capture ownership rule matched .json only, so the first recorded
xctrace export under a package fixture directory had no derivable owner and
failed the gate open to all 59 checks even though exactly one suite reads it.
Accept .xml beside .json and pin both spellings in the ownership test.
* test(ios): synthesize the Xcode 27 time-profile rows instead of committing a capture
The captured export leaked a machine's home directory, per-user temp-dir token,
and installed-software identity — an MDM endpoint-security agent among them —
into a public repo, and a 30 KB blob of 2000-char lines defeats diff, format, and
grep for coverage the synthetic rows already give.
Keep the shapes that capture proved: a `<tagged-backtrace>` definition, a row that
names its stack by ref, a `truncated="YES"` stack whose innermost frame is a
`<frame ref>`, an innermost `<binary ref>`, and a stack-column `<sentinel/>` row.
The binary-ref case is the one the pre-existing suite survived before. Symbols,
binaries, and weights are synthetic.
Give the cross-run frame reference its own test, so the multi-run aggregation case
keeps answering independently the way it did before this PR.
* chore(gates): drop the .xml package-capture extension
That extension was added only to own the captured xctrace export this branch no
longer commits, so the rule would own nothing real. Revert to the `.json` capture
rule and keep the ownership test on the captures that exist.1 parent 7286206 commit 0192348
3 files changed
Lines changed: 90 additions & 3 deletions
File tree
- packages/platform-apple/src/core
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
5 | 11 | | |
6 | 12 | | |
7 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
5 | 57 | | |
6 | 58 | | |
7 | 59 | | |
| |||
44 | 96 | | |
45 | 97 | | |
46 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
47 | 123 | | |
48 | 124 | | |
49 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
| |||
78 | 83 | | |
79 | 84 | | |
80 | 85 | | |
81 | | - | |
82 | | - | |
| 86 | + | |
| 87 | + | |
83 | 88 | | |
84 | 89 | | |
85 | 90 | | |
86 | 91 | | |
87 | 92 | | |
88 | | - | |
| 93 | + | |
89 | 94 | | |
90 | 95 | | |
91 | 96 | | |
| |||
0 commit comments