You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 017113c
Browse filesBrowse the repository at this point in the historyBrowse files
fix(daemon): record only the tree a mutation actually acted through (#3471)
`chooseMovingTargetTree` preferred the session snapshot whenever its node array
differed from the tree the action resolved against, reasoning that a `--settle`
or `--verify` capture must have published something newer. Array identity cannot
establish that: a freshness capture and a `@ref` press's authorized frame reach
`session.snapshot` the same way, so the marker could record a surface this action
never looked at — the exact substitution its own docblock forbids, and a
`stationary` verdict made against the wrong tree. The baseline is now the
acted-through tree, always. A settled press simply owes its successor one
re-observation instead of being answered from a tree of unknown provenance.
The corroborated-failure path also dropped the tree. That sibling call reached
the same finalizer without `preActionTree`, so a corroborated iOS tap retired the
baseline a previous mutation had recorded and left the next press unscreened — a
dispatch that touched the device behaving like one that never looked at a tree.
It now passes the resolved target's own tree.
Help and website docs now scope the guarantee to what the gate actually covers:
ref and selector targets on the runtime path, dispatched (not "tapped") at the
resting position, `movedToRect` optional, and a raw-coordinate press explicitly
outside it.
Refusing to narrow the WRITER to press/click: the ADR 0011 cells scope which
commands the gate guards, while this marker asks whether a mutation just left an
animating surface, and a `fill` that opened a keyboard or a `longpress` that
started a drag answers that the same way a press does. The breadth is now pinned
by a test rather than left implicit.
Copy file name to clipboardExpand all lines: src/commands/interaction/metadata.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -57,9 +57,9 @@ const FIND_ACTION_VALUES = [
57
57
58
58
constinteractionCommandDescriptions={
59
59
click:
60
-
"Activate a UI target by snapshot ref, selector, or coordinates. Prefer a ref or selector after a snapshot; use coordinates only when semantic targeting is unavailable. This can change app state. Success means the click was dispatched, not that it landed: use settle or verify to confirm the result without a follow-up snapshot, or wait for the expected screen. A target still moving shortly after the session's previous action is re-observed and tapped at its resting position; one that has not stopped refuses with target_still_moving rather than tapping where it was.",
60
+
"Activate a UI target by snapshot ref, selector, or coordinates. Prefer a ref or selector after a snapshot; use coordinates only when semantic targeting is unavailable. This can change app state. Success means the click was dispatched, not that it landed: use settle or verify to confirm the result without a follow-up snapshot, or wait for the expected screen. A ref or selector target is re-checked for motion before dispatch when the session's previous action just animated the screen, and is dispatched at its resting position; one that has not stopped refuses with target_still_moving rather than acting where it was.",
61
61
press:
62
-
"Short-press a UI target by snapshot ref, selector, or coordinates. Use longpress instead when the target requires a context-menu or hold gesture. Success means the press was dispatched, not that it landed: use settle or verify to confirm the result, or wait for the expected screen. A target still moving shortly after the session's previous action is re-observed and tapped at its resting position; one that has not stopped refuses with target_still_moving rather than tapping where it was.",
62
+
"Short-press a UI target by snapshot ref, selector, or coordinates. Use longpress instead when the target requires a context-menu or hold gesture. Success means the press was dispatched, not that it landed: use settle or verify to confirm the result, or wait for the expected screen. A ref or selector target is re-checked for motion before dispatch when the session's previous action just animated the screen, and is dispatched at its resting position; one that has not stopped refuses with target_still_moving rather than acting where it was.",
63
63
fill: 'Replace text in a UI input selected by snapshot ref, selector, or coordinates. Pass an empty text to clear the field. Inspect unconfirmed evidence and assert the expected value or resulting screen before continuing. Prefer refs or selectors after snapshot; use recordAs to keep sensitive text out of a recorded replay while sending it to the live app.',
64
64
longpress:
65
65
'Hold a UI target by snapshot ref, selector, or coordinates to open a context menu or perform another hold gesture. Set durationMs when the default hold duration is unsuitable.',
A successful `click` or `press` means the action was sent to where the command found the target. It does not confirm that the element received it or that the screen changed. When the next step depends on it, add `--verify` (reports `changedFromBefore`), add `--settle` (returns the diff once the UI goes quiet), or follow with `wait <selector>`. Before retrying a failed interaction, see [Retry after a failed command](#retry-after-a-failed-command).
424
424
425
-
A `click` or `press` that follows an action which animated the screen checks the target's position again before tapping, and taps where it came to rest. A target still moving when that check runs out refuses with `target_still_moving` and `dispatched: no`: nothing was tapped, so the point the command resolved is in `error.details.rect` and where the target was last seen is `error.details.movedToRect`. Run `wait <selector>` on the target and retry the same command, or add `--settle` so the action waits for the UI to go quiet. A refused `@ref` press needs a fresh `snapshot -i` and a selector, because the wait retires the ref.
425
+
A `click` or `press` that names its target by `@ref` or selector, and follows an action which animated the screen, checks the target's position again before dispatching, and dispatches where it came to rest. A target still moving when that check runs out refuses with `target_still_moving` and `dispatched: no`: nothing was tapped, the point the command resolved is in `error.details.rect`, and where the target was last seen is in `error.details.movedToRect` when that last look measured one. Run `wait <selector>` on the target and retry the same command, or add `--settle` so the action waits for the UI to go quiet. A refused `@ref` press needs a fresh `snapshot -i` and a selector, because the wait retires the ref. A press at raw coordinates has no target to re-check.
0 commit comments