Repository navigation
Expand file tree
/
Copy pathsession-state.ts
More file actions
715 lines (677 loc) · 28.9 KB
/
Copy pathsession-state.ts
File metadata and controls
715 lines (677 loc) · 28.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
/** SessionState field ownership for assignments, named patches and record copies. */
import { parseSync } from 'oxc-parser';
import { memberName, memberPath, propertyName, visitAst } from './layering-ast.ts';
import path from 'node:path';
export type SessionStateWrite = {
file: string;
line: number;
field: string;
};
/**
* Which modules may write each `SessionState` field, as paths under `src/`. A field whose
* owner list has one entry is a field only that module can get wrong.
*/
export const SESSION_STATE_FIELD_OWNERS: Readonly<Record<string, readonly string[]>> = {
// ADR 0014 ref frame. The four frame fields this row replaced moved together or the frame was
// incoherent, and only this table said so; `RefFrame` is now a nominal type (`#`-private
// fields) that no other module can construct, edit, or spread into a new frame, and the
// transitions replace it whole. The row stays because the type cannot judge a whole frame
// moved unchanged: assigning `undefined` (a reset to the pristine frame) and assigning a
// frame read off another session.
refFrame: ['src/daemon/ref-frame.ts'],
// Scoped-snapshot lineage is cleared at two distinct events: crossing a device side-effect
// seam (ref-frame.ts) and replacing the stored observation (session-snapshot.ts).
snapshotScopeSource: ['src/daemon/ref-frame.ts', 'src/daemon/session-snapshot.ts'],
snapshot: ['src/daemon/session-snapshot.ts'],
snapshotGeneration: ['src/daemon/session-snapshot.ts'],
lastComparisonSafeSnapshot: ['src/daemon/session-snapshot.ts'],
androidSnapshotFreshness: ['src/daemon/session-snapshot-freshness.ts'],
// One-shot deferred-warning latch (#1587 follow-up): the transition function is the only
// writer, so the latch's window semantics live in a single module.
recoveredSnapshotWarningLatch: ['src/daemon/snapshot-quality-latch.ts'],
// #1478 P4a script publication. The tagged aggregate replaced the eight co-resident
// `saveScript*`/`scriptRecordingState`/`repair*` fields; its ONLY writers are the two
// daemon-private projections (`session-replay-transaction.ts`,
// `session-script-publication-capability.ts`) and the writer's commit transition.
// It also absorbed `recordSession`, whose separate ownership let handler surfaces arm
// recording without moving the lifecycle that authorized it (#1533). Recording is now derived
// (`isRecordingPublication`), so there is no second field to keep in step.
scriptPublication: [
'src/daemon/session-replay-transaction.ts',
'src/daemon/session-script-publication-capability.ts',
'src/daemon/session-script-writer.ts',
],
// #1478 P4b: moved from `session-replay-resume.ts` into the `ReplayCoordinator`
// (`session-replay-coordinator.ts`) — the one locked gateway a native replay request uses to
// reach both this watermark and the P4a `scriptPublication` transitions above.
pendingRecordAndHeal: ['src/daemon/session-replay-coordinator.ts'],
trace: ['src/daemon/handlers/trace-runtime.ts'],
postGestureStabilization: ['src/daemon/deferred-interaction-outcome.ts'],
// App identity follows open, deployment and observation through named patches.
appName: [
'src/daemon/handlers/session-app-deployment.ts',
'src/daemon/session-lifecycle/internal/session-open-state.ts',
'src/daemon/snapshot-command-runtime.ts',
],
appBundleId: [
'src/daemon/handlers/session-app-deployment.ts',
'src/daemon/handlers/session-selector-dispatch.ts',
'src/daemon/session-lifecycle/internal/session-open-state.ts',
],
appLog: ['src/daemon/app-log-session-resource.ts'],
appLogFailure: ['src/daemon/app-log-session-resource.ts'],
audioProbe: ['src/daemon/session-capture-binding.ts'],
perfCapture: ['src/daemon/session-capture-binding.ts'],
screenRecording: ['src/daemon/session-capture-binding.ts'],
lastPerfProfile: ['src/daemon/session-observability/internal/session-perf-runtime.ts'],
device: ['src/daemon/session-lifecycle/internal/session-open-state.ts'],
surface: ['src/daemon/session-lifecycle/internal/session-open-state.ts'],
// Open execution owns the paired lease/claim transition after the handler has admitted one
// lifecycle binding. Keeping the records together prevents request-policy routing from gaining
// a second durable owner as the execution seam stays package-bound.
lease: [
'src/daemon/lease-lifecycle.ts',
'src/daemon/session-lifecycle/internal/session-open-state.ts',
],
deviceClaim: ['src/daemon/session-lifecycle/internal/session-open-state.ts'],
// #1398 (ADR 0017 session-scoped echo protection amendment): the ephemeral
// literal->placeholder registry is populated and consulted only at the
// recorder's single choke point.
recordedFillLiterals: ['src/daemon/session-action-recorder.ts'],
};
/**
* Fields no daemon module writes through a session binding: they are set when the record is
* constructed (an object literal, not a field assignment) or inside `session-store.ts`, which
* owns the record and is excluded from the scan.
*
* This list exists so the classification is EXHAUSTIVE. Without it, a new `SessionState` field
* that happened to have no direct write would satisfy the gate by being invisible to it, and R7
* would silently stop covering part of the type it claims to cover. Being here is a positive
* claim — "the store establishes this, nothing mutates it later" — so acquiring a direct write
* fails the gate until the field is moved into `SESSION_STATE_FIELD_OWNERS` with a real owner.
*/
export const STORE_OWNED_SESSION_STATE_FIELDS: ReadonlySet<string> = new Set([
'actions',
'createdAt',
// #2833: the request path reports session activity through `SessionStore.noteSessionActivity`, so
// the only writer of this field is the store that owns the record.
'lastActivityAtMs',
'name',
'recordOnlySession',
'sessionScope',
'snapshotDiagnostics',
]);
export function sessionStateFieldCount(): number {
return Object.keys(SESSION_STATE_FIELD_OWNERS).length + STORE_OWNED_SESSION_STATE_FIELDS.size;
}
export type FieldClassificationDrift = {
field: string;
problem: 'unclassified' | 'both' | 'not-a-field';
};
/**
* Where the two ownership tables disagree with `SessionState` itself. Empty means every declared
* field is classified exactly once and neither table names a field that no longer exists.
*/
export function fieldClassificationDrift(fields: readonly string[]): FieldClassificationDrift[] {
const declared = new Set(fields);
const owned = new Set(Object.keys(SESSION_STATE_FIELD_OWNERS));
const drift: FieldClassificationDrift[] = [];
for (const field of fields) {
const inOwners = owned.has(field);
const inStore = STORE_OWNED_SESSION_STATE_FIELDS.has(field);
if (inOwners && inStore) drift.push({ field, problem: 'both' });
else if (!inOwners && !inStore) drift.push({ field, problem: 'unclassified' });
}
for (const field of [...owned, ...STORE_OWNED_SESSION_STATE_FIELDS]) {
if (!declared.has(field)) drift.push({ field, problem: 'not-a-field' });
}
return drift.sort((left, right) => left.field.localeCompare(right.field));
}
const SESSION_STATE_DECLARATION = /export type SessionState = \{([\s\S]*?)\n\};/;
/**
* The daemon module that declares `SessionState`, found by the declaration rather than by a
* recorded path. `sessionStateWritePressure` below measures the merge-base tree with the same
* function, and that tree's declaration may still sit where this tree no longer has it — a
* path constant would silently measure such a tree as zero pressure and bank the headroom.
*/
export function sessionStateDeclarationFile(
sources: ReadonlyMap<string, string>,
): string | undefined {
for (const [file, source] of sources) {
if (file.startsWith('src/daemon/') && SESSION_STATE_DECLARATION.test(source)) return file;
}
return undefined;
}
/**
* Field names declared by `SessionState` itself, so the scan cannot be fooled by a daemon
* module with an unrelated local named `session` (a provider session, a runner session).
*/
export function sessionStateFields(typesSource: string): string[] {
const declaration = SESSION_STATE_DECLARATION.exec(typesSource);
if (!declaration) throw new Error('SessionState declaration not found');
return [...declaration[1]!.matchAll(/^ {2}([a-zA-Z][A-Za-z0-9]*)\??:/gm)].map(
(match) => match[1]!,
);
}
/**
* Whether a binding holds a `SessionState`. The daemon names these records by role, not always
* `session`: `nextSession`, `provisionalSession`, `completedSession`, `preRunSession`,
* `preEntrySession`, `activeSession`. Matching only the literal name `session` is what let three
* genuine foreign writes sit unreported — `nextSession.snapshotGeneration` in snapshot-runtime.ts
* among them — while the gate claimed every write was inside its owner.
*
* There is no type information here, so this is a name test, and it is deliberately paired with
* the declared-field filter in `findSessionStateWrites`: a binding must look like a session AND
* the field must be one `SessionState` declares. A provider or runner session that happens to be
* named `…Session` only registers if it also writes a field name `SessionState` owns, and the
* remedy then is to declare the owner — the same remedy as for a real write.
*/
function isSessionBinding(name: string): boolean {
return /session/i.test(name);
}
/** A member expression being assigned to, or updated with `++`/`--`. */
type WriteTarget = {
object: unknown;
field: string | undefined;
computed: boolean;
offset: number;
};
function writeTarget(node: Record<string, unknown>): WriteTarget | null {
const type = node['type'];
const candidate =
type === 'AssignmentExpression'
? (node['left'] as Record<string, unknown> | undefined)
: type === 'UpdateExpression'
? (node['argument'] as Record<string, unknown> | undefined)
: undefined;
const member = unwrapExpression(candidate);
if (member?.['type'] !== 'MemberExpression') return null;
const object = member['object'] as Record<string, unknown> | undefined;
const property = member['property'] as Record<string, unknown> | undefined;
return {
object,
field: property?.['type'] === 'Identifier' ? (property['name'] as string) : undefined,
computed: member['computed'] === true,
offset: typeof member['start'] === 'number' ? member['start'] : 0,
};
}
function lineOf(source: string, offset: number): number {
let line = 1;
for (let index = 0; index < offset && index < source.length; index++) {
if (source[index] === '\n') line++;
}
return line;
}
type AstNode = Record<string, unknown>;
function astNode(value: unknown): AstNode | undefined {
return value !== null && typeof value === 'object' && !Array.isArray(value)
? (value as AstNode)
: undefined;
}
function unwrapExpression(value: unknown): AstNode | undefined {
let node = astNode(value);
while (
node &&
[
'TSAsExpression',
'TSSatisfiesExpression',
'TSNonNullExpression',
'ParenthesizedExpression',
'ChainExpression',
].includes(String(node.type))
) {
node = astNode(node.expression);
}
return node;
}
function isSessionStoreReceiver(value: unknown, storeBindings: ReadonlySet<string>): boolean {
const members = memberPath(value);
return members !== undefined && storeBindings.has(members.at(-1)!);
}
function isSessionRecord(
value: unknown,
sessionBindings: ReadonlySet<string>,
sessionRefBindings: ReadonlySet<string>,
sessionRefPaths: ReadonlySet<string>,
storeBindings: ReadonlySet<string>,
): boolean {
const node = unwrapExpression(value);
return node?.type === 'Identifier'
? sessionBindings.has(String(node.name))
: node?.type === 'MemberExpression' &&
memberName(node) === 'session' &&
(node.computed !== true || astNode(node.property)?.type === 'Literal') &&
isSessionRefValue(node.object, sessionRefBindings, sessionRefPaths, storeBindings);
}
function isSessionRead(value: unknown, storeBindings: ReadonlySet<string>): boolean {
const node = unwrapExpression(value);
if (!node) return false;
if (node.type === 'LogicalExpression') return isSessionRead(node.left, storeBindings);
const callee = astNode(node.callee);
return (
node.type === 'CallExpression' &&
callee?.type === 'MemberExpression' &&
['get', 'requireCurrent', 'resolveCurrent'].includes(memberName(callee) ?? '') &&
isSessionStoreReceiver(callee.object, storeBindings)
);
}
function isSessionRecordOrRead(
value: unknown,
sessionBindings: ReadonlySet<string>,
sessionRefBindings: ReadonlySet<string>,
sessionRefPaths: ReadonlySet<string>,
storeBindings: ReadonlySet<string>,
): boolean {
return (
isSessionRecord(value, sessionBindings, sessionRefBindings, sessionRefPaths, storeBindings) ||
isSessionRead(value, storeBindings)
);
}
function isSessionRefValue(
value: unknown,
sessionRefBindings: ReadonlySet<string>,
sessionRefPaths: ReadonlySet<string>,
storeBindings: ReadonlySet<string>,
): boolean {
const node = unwrapExpression(value);
if (!node) return false;
if (node.type === 'LogicalExpression')
return (
isSessionRefValue(node.left, sessionRefBindings, sessionRefPaths, storeBindings) ||
isSessionRefValue(node.right, sessionRefBindings, sessionRefPaths, storeBindings)
);
if (node.type === 'Identifier' && sessionRefBindings.has(String(node.name))) return true;
if (node.type === 'MemberExpression') {
const path = memberPath(node);
if (path && sessionRefPaths.has(path.join('\0'))) return true;
}
const callee = astNode(node.callee);
return (
node.type === 'CallExpression' &&
callee?.type === 'MemberExpression' &&
['lookup', 'publish', 'findByDevice', 'refresh'].includes(memberName(callee) ?? '') &&
isSessionStoreReceiver(callee.object, storeBindings)
);
}
function hasNamedType(node: AstNode, name: string): boolean {
const annotation = astNode(astNode(node.typeAnnotation)?.typeAnnotation);
return annotation?.type === 'TSTypeReference' && propertyName(annotation.typeName) === name;
}
function sessionRefPropertyPaths(node: AstNode): string[][] {
const paths: string[][] = [];
const collect = (type: AstNode | undefined, prefix: readonly string[]): void => {
if (type?.type !== 'TSTypeLiteral') return;
for (const member of type.members as AstNode[]) {
if (member.type !== 'TSPropertySignature') continue;
const field = propertyName(member.key);
if (!field) continue;
if (hasNamedType(member, 'SessionRef')) paths.push([...prefix, field]);
else collect(astNode(astNode(member.typeAnnotation)?.typeAnnotation), [...prefix, field]);
}
};
collect(astNode(astNode(node.typeAnnotation)?.typeAnnotation), []);
return paths;
}
function hasObjectRestPattern(pattern: AstNode): boolean {
const properties = pattern.properties as AstNode[] | undefined;
return properties?.some((property) => property.type === 'RestElement') === true;
}
function collectPatchReturns(value: unknown, returns: AstNode[]): void {
if (Array.isArray(value)) {
for (const child of value) collectPatchReturns(child, returns);
return;
}
const node = astNode(value);
if (!node) return;
if (node.type === 'ReturnStatement') {
returns.push(node);
return;
}
if (
['FunctionDeclaration', 'FunctionExpression', 'ArrowFunctionExpression'].includes(
String(node.type),
)
)
return;
for (const child of Object.values(node)) collectPatchReturns(child, returns);
}
function bindSessionRefProperties(pattern: AstNode, sessionBindings: Set<string>): void {
for (const property of pattern.properties as AstNode[]) {
if (property.type !== 'Property') continue;
const key = astNode(property.key);
const field = propertyName(property.key);
if (
property.computed === true
? key?.type === 'Literal' && field !== 'session'
: field !== 'session'
)
continue;
const value = astNode(property.value);
const binding = value?.type === 'AssignmentPattern' ? astNode(value.left) : value;
if (binding?.type === 'Identifier') sessionBindings.add(String(binding.name));
}
}
function patchObjects(value: unknown): AstNode[] | undefined {
const patch = unwrapExpression(value);
if (!patch) return undefined;
if (patch.type === 'ObjectExpression') return [patch];
if (
!['ArrowFunctionExpression', 'FunctionExpression'].includes(String(patch.type)) ||
patch.async === true
)
return undefined;
const body = unwrapExpression(patch.body);
if (body?.type === 'ObjectExpression') return [body];
if (body?.type !== 'BlockStatement') return undefined;
const returns: AstNode[] = [];
collectPatchReturns(body, returns);
if (returns.length !== 1 || !(body.body as AstNode[]).includes(returns[0]!)) return undefined;
const result = unwrapExpression(returns[0]!.argument);
return result?.type === 'ObjectExpression' ? [result] : undefined;
}
const SESSION_STATE_SCAN_ROOTS = ['src/daemon/', 'packages/capture-kit/src/capture-admission/'];
const SESSION_DRAFT_CONSTRUCTORS: Readonly<Record<string, string>> = {
'src/daemon/session-lifecycle/internal/session-open-state.ts': 'publishOpenSession',
'src/daemon/snapshot-session.ts': 'createSnapshotSession',
'src/daemon/handlers/record-runtime.ts': 'createRecordOnlySession',
};
/** Assignments, named update keys and whole-record copies at the session ownership seam. */
export function findSessionStateWrites(
sources: ReadonlyMap<string, string>,
fields: readonly string[],
): SessionStateWrite[] {
const declared = new Set(fields);
const writes: SessionStateWrite[] = [];
for (const [file, source] of sources) {
if (!SESSION_STATE_SCAN_ROOTS.some((root) => file.startsWith(root))) continue;
if (path.posix.basename(file) === 'session-store.ts') continue;
const program = parseSync(file, source).program;
const sessionBindings = new Set<string>();
const sessionRefBindings = new Set<string>();
const sessionRefPaths = new Set<string>();
const storeBindings = new Set(['store', 'sessionStore']);
const aliases: Array<readonly [string, unknown]> = [];
const objectDestructurings: Array<readonly [AstNode, unknown]> = [];
const recordRestPatterns = new Map<AstNode, unknown>();
const patches = new Set<AstNode>();
const report = (node: AstNode, field: string): void => {
writes.push({ file, line: lineOf(source, Number(node.start ?? 0)), field });
};
visitAst(program, (node) => {
if (node.type === 'Identifier') {
if (isSessionBinding(String(node.name)) || hasNamedType(node, 'SessionState'))
sessionBindings.add(String(node.name));
if (hasNamedType(node, 'SessionRef')) sessionRefBindings.add(String(node.name));
if (hasNamedType(node, 'SessionStore')) storeBindings.add(String(node.name));
for (const path of sessionRefPropertyPaths(node))
sessionRefPaths.add([String(node.name), ...path].join('\0'));
}
if (node.type === 'VariableDeclarator') {
const id = astNode(node.id);
if (id?.type === 'Identifier') {
aliases.push([String(id.name), node.init]);
}
if (id?.type === 'ObjectPattern') {
objectDestructurings.push([id, node.init]);
if (hasObjectRestPattern(id)) recordRestPatterns.set(id, node.init);
}
}
if (node.type === 'ObjectPattern') {
if (hasNamedType(node, 'SessionRef')) bindSessionRefProperties(node, sessionBindings);
if (hasObjectRestPattern(node) && hasNamedType(node, 'SessionState'))
recordRestPatterns.set(node, undefined);
for (const property of node.properties as AstNode[]) {
if (property.type !== 'Property') continue;
const field = property.computed === true ? undefined : propertyName(property.key);
const value = astNode(property.value);
const binding = value?.type === 'AssignmentPattern' ? astNode(value.left) : value;
if (binding?.type !== 'Identifier') continue;
if (field === 'store' || field === 'sessionStore')
storeBindings.add(String(binding.name));
}
}
});
const inheritAliases = (): void => {
let added: boolean;
do {
added = false;
for (const [name, value] of aliases) {
if (!storeBindings.has(name) && isSessionStoreReceiver(value, storeBindings)) {
storeBindings.add(name);
added = true;
}
if (
!sessionBindings.has(name) &&
(isSessionRecord(
value,
sessionBindings,
sessionRefBindings,
sessionRefPaths,
storeBindings,
) ||
isSessionRead(value, storeBindings))
) {
sessionBindings.add(name);
added = true;
}
if (
!sessionRefBindings.has(name) &&
isSessionRefValue(value, sessionRefBindings, sessionRefPaths, storeBindings)
) {
sessionRefBindings.add(name);
added = true;
}
}
for (const [pattern, value] of objectDestructurings) {
if (isSessionRefValue(value, sessionRefBindings, sessionRefPaths, storeBindings)) {
const bindingCount = sessionBindings.size;
bindSessionRefProperties(pattern, sessionBindings);
if (sessionBindings.size !== bindingCount) added = true;
}
const sourcePath = memberPath(unwrapExpression(value));
if (!sourcePath) continue;
for (const property of pattern.properties as AstNode[]) {
if (
property.type !== 'Property' ||
(property.computed === true && astNode(property.key)?.type !== 'Literal')
)
continue;
const field = propertyName(property.key);
const value = astNode(property.value);
const binding = value?.type === 'AssignmentPattern' ? astNode(value.left) : value;
if (
field &&
binding?.type === 'Identifier' &&
!sessionRefBindings.has(String(binding.name)) &&
sessionRefPaths.has([...sourcePath, field].join('\0'))
) {
sessionRefBindings.add(String(binding.name));
added = true;
}
}
}
} while (added);
};
inheritAliases();
visitAst(program, (node) => {
const callee = astNode(node.callee);
const args = node.arguments as unknown[] | undefined;
if (
node.type !== 'CallExpression' ||
callee?.type !== 'MemberExpression' ||
memberName(callee) !== 'update' ||
args?.length !== 2 ||
!isSessionStoreReceiver(callee.object, storeBindings)
)
return;
const patch = unwrapExpression(args[1]);
const objects = patchObjects(args[1]);
if (!objects) {
report(patch ?? node, '[patch-shape]');
return;
}
if (patch?.type !== 'ObjectExpression') {
const binding = astNode((patch?.params as unknown[])?.[0]);
if (binding?.type === 'Identifier') sessionBindings.add(String(binding.name));
visitAst(patch?.body, (inner) => {
const target = astNode(inner.callee);
if (
inner.type === 'CallExpression' &&
target?.type === 'MemberExpression' &&
isSessionStoreReceiver(target.object, storeBindings)
)
report(inner, '[reentrant-patch]');
});
}
for (const object of objects) {
patches.add(object);
for (const property of object.properties as AstNode[]) {
if (
property.type !== 'Property' ||
property.computed === true ||
property.method === true ||
property.kind !== 'init'
)
report(property, '[patch-shape]');
else report(property, propertyName(property.key) ?? '[patch-shape]');
}
}
});
inheritAliases();
for (const [pattern, source] of recordRestPatterns) {
if (
hasNamedType(pattern, 'SessionState') ||
isSessionRecordOrRead(
source,
sessionBindings,
sessionRefBindings,
sessionRefPaths,
storeBindings,
)
) {
report(pattern, '[whole-record-spread]');
for (const property of pattern.properties as AstNode[]) {
const binding = property.type === 'RestElement' ? astNode(property.argument) : undefined;
if (binding?.type === 'Identifier') sessionBindings.add(String(binding.name));
}
}
}
inheritAliases();
const walk = (value: unknown, ancestors: readonly AstNode[]): void => {
if (Array.isArray(value)) {
for (const child of value) walk(child, ancestors);
return;
}
const node = astNode(value);
if (!node) return;
const target = writeTarget(node);
if (
target &&
isSessionRecord(
target.object,
sessionBindings,
sessionRefBindings,
sessionRefPaths,
storeBindings,
)
) {
if (target.computed) report(node, '[computed]');
else if (target.field !== undefined && declared.has(target.field))
report(node, target.field);
}
if (node.type === 'CallExpression') {
const callee = unwrapExpression(node.callee);
const args = node.arguments as unknown[] | undefined;
const objectAssign =
callee?.type === 'MemberExpression' &&
memberName(callee) === 'assign' &&
astNode(callee.object)?.type === 'Identifier' &&
astNode(callee.object)?.name === 'Object';
const structuredClone = callee?.type === 'Identifier' && callee.name === 'structuredClone';
if (
(objectAssign || structuredClone) &&
args?.some((argument) =>
isSessionRecordOrRead(
argument,
sessionBindings,
sessionRefBindings,
sessionRefPaths,
storeBindings,
),
)
)
report(node, '[whole-record-spread]');
}
if (node.type === 'ObjectExpression' && !patches.has(node)) {
const properties = node.properties as AstNode[];
const copiesRecord = properties.some((property) => {
if (property.type !== 'SpreadElement') return false;
return isSessionRecordOrRead(
property.argument,
sessionBindings,
sessionRefBindings,
sessionRefPaths,
storeBindings,
);
});
if (copiesRecord) {
const enclosingFunction = [...ancestors]
.reverse()
.find((ancestor) =>
['FunctionDeclaration', 'FunctionExpression', 'ArrowFunctionExpression'].includes(
String(ancestor.type),
),
);
const constructor = propertyName(enclosingFunction?.id);
const parent = ancestors.at(-1);
const publishedDraft = file.endsWith('/session-open-state.ts')
? parent?.type === 'CallExpression' &&
memberName(astNode(parent.callee) ?? {}) === 'publish' &&
(parent.arguments as unknown[])[1] === node
: true;
const draft = SESSION_DRAFT_CONSTRUCTORS[file];
if (!draft || constructor !== draft || !publishedDraft) {
report(node, '[whole-record-spread]');
for (const property of properties) {
const field = propertyName(property.key);
if (property.type === 'Property' && declared.has(field ?? ''))
report(property, field!);
}
}
}
}
for (const child of Object.values(node)) walk(child, [...ancestors, node]);
};
walk(program, []);
}
return writes.sort(
(left, right) => left.file.localeCompare(right.file) || left.line - right.line,
);
}
export type SessionStateWritePressure = Readonly<{
/** Declared fields written by an owner through assignments, patches or record copies. */
writerOwnedFields: number;
/** Distinct (field, writing module) pairs — what `SESSION_STATE_FIELD_OWNERS` claims. */
ownerFileClaims: number;
}>;
/**
* R10 measures how many declared fields have a writer, and how many
* module claims that takes. Read from the tree rather than from the ownership table, so the same
* function measures a merge-base tree whose table is not in scope. On a tree R7 accepts, both
* numbers equal the table's own size.
*/
export function sessionStateWritePressure(
sources: ReadonlyMap<string, string>,
): SessionStateWritePressure {
const declarationFile = sessionStateDeclarationFile(sources);
if (!declarationFile) return { writerOwnedFields: 0, ownerFileClaims: 0 };
const fields = sessionStateFields(sources.get(declarationFile)!);
const declared = new Set(fields);
const writes = findSessionStateWrites(sources, fields).filter((write) =>
declared.has(write.field),
);
return {
writerOwnedFields: new Set(writes.map((write) => write.field)).size,
ownerFileClaims: new Set(writes.map((write) => `${write.field}\0${write.file}`)).size,
};
}