Skip to content

Commit cb6d49b

Browse files
Philclaude
andcommitted
test: guard no pop callbacks for the top page on a re-check (flutter/flutter#189578)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 614a9ce commit cb6d49b

1 file changed

Lines changed: 95 additions & 0 deletions

File tree

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
import 'dart:async';
2+
3+
import 'package:auto_route/auto_route.dart';
4+
import 'package:flutter_test/flutter_test.dart';
5+
import 'package:material_ui/material_ui.dart';
6+
7+
import '../router_test_utils.dart';
8+
9+
class _Observer extends AutoRouterObserver {
10+
final events = <String>[];
11+
12+
@override
13+
void didPop(Route<dynamic> route, Route<dynamic>? previousRoute) => events.add('didPop ${route.settings.name}');
14+
15+
@override
16+
void didRemove(Route<dynamic> route, Route<dynamic>? previousRoute) => events.add('didRemove ${route.settings.name}');
17+
18+
@override
19+
void didReplace({Route<dynamic>? newRoute, Route<dynamic>? oldRoute}) => events.add('didReplace');
20+
}
21+
22+
class _EditPage extends StatefulWidget {
23+
const _EditPage({required this.onPop});
24+
25+
final VoidCallback onPop;
26+
27+
@override
28+
State<_EditPage> createState() => _EditPageState();
29+
}
30+
31+
class _EditPageState extends State<_EditPage> {
32+
static int inits = 0;
33+
34+
@override
35+
void initState() {
36+
super.initState();
37+
inits++;
38+
}
39+
40+
@override
41+
Widget build(BuildContext context) {
42+
return PopScope(
43+
canPop: false,
44+
onPopInvokedWithResult: (_, _) => widget.onPop(),
45+
child: const Scaffold(body: Text('EditRoute')),
46+
);
47+
}
48+
}
49+
50+
void main() {
51+
// https://github.com/flutter/flutter/issues/189578
52+
// In go_router, onExit ran for a pushed route each time refreshListenable
53+
// fired, as if the user had left it.
54+
// Steps: push EditRoute, which holds a PopScope with an unsaved-changes
55+
// callback, and an observer on the router; fire reevaluateListenable three
56+
// times while EditRoute is on top.
57+
// Should: no pop callback, no didPop, didRemove or didReplace, and
58+
// EditRoute's state is kept.
59+
testWidgets('A reevaluation calls no pop callback for the page on top (flutter/flutter#189578)', (tester) async {
60+
final user = ValueNotifier(0);
61+
addTearDown(user.dispose);
62+
final observer = _Observer();
63+
var popCallbacks = 0;
64+
_EditPageState.inits = 0;
65+
final router = RootStackRouter.build(
66+
guards: [AutoRouteGuard.simple((resolver, _) => resolver.next())],
67+
routes: [
68+
NamedRouteDef(
69+
name: 'HomeRoute',
70+
path: '/',
71+
builder: (_, _) => const Scaffold(body: Text('HomeRoute')),
72+
),
73+
NamedRouteDef(
74+
name: 'EditRoute',
75+
path: '/edit',
76+
builder: (_, _) => _EditPage(onPop: () => popCallbacks++),
77+
),
78+
],
79+
);
80+
await pumpRouterApp(tester, router, reevaluationNotifier: user, observers: () => [observer]);
81+
unawaited(router.pushPath('/edit'));
82+
await tester.pumpAndSettle();
83+
observer.events.clear();
84+
85+
for (var i = 0; i < 3; i++) {
86+
user.value++;
87+
await tester.pumpAndSettle();
88+
}
89+
90+
expect(popCallbacks, 0);
91+
expect(observer.events, isEmpty);
92+
expect(_EditPageState.inits, 1);
93+
expectTopPage(router, 'EditRoute');
94+
});
95+
}

0 commit comments

Comments
 (0)