Skip to content

fix: Booking questions order correction in confirmation email #18192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Udit-takkar merged 2 commits into from
Dec 16, 2024
Merged

fix: Booking questions order correction in confirmation email #18192

Udit-takkar merged 2 commits into from
Dec 16, 2024

Conversation

@VenkataRohan
Copy link
Contributor

@VenkataRohan VenkataRohan commented Dec 15, 2024

What does this PR do?

Added code to preserve the order of Questions asked during booking in the conformation email.
Please check the below video.

cal_question_order.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link

vercel bot commented Dec 15, 2024

@VenkataRohan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team December 15, 2024 09:20
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 15, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Dec 15, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Dec 15, 2024
@graphite-app
Copy link

graphite-app bot commented Dec 15, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/15/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/16/24)

1 label was added to this PR based on Keith Williams's automation.

Udit-takkar
Udit-takkar approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Udit-takkar Udit-takkar added this to the v4.9 milestone Dec 16, 2024
@Udit-takkar Udit-takkar enabled auto-merge (squash) December 16, 2024 09:12
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

E2E results are ready!

@Udit-takkar Udit-takkar merged commit da2c57c into calcom:main Dec 16, 2024
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees

No one assigned

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email Low priority Created by Linear-GitHub Sync ready-for-e2e

Projects

None yet

Milestone

v4.9

Development

Successfully merging this pull request may close these issues.

[CAL-4071] Booking questions apear in wrong order in confirmation email

3 participants

@VenkataRohan @CLAassistant @Udit-takkar