@MasterOdin Can we tag a new patch release after this, please? So we are good for Core migrations plugin to also be green?

Feel free to add a test if you have some time.
Once this is merged, the migrations PR should also be green I guess.

TIL that instanceof will not error if the right-hand operator points at a class that doesn't exist in the current environment.

So cakephp/i18n just needs to be a require-dev entry for the linter and analyzer to pass, but doesn't need to be there for downstream consumers (unless they want to use it for bulk inserts).

I double checked: cakephp/migrations#843 green :)

Given the different ms before/after the regex was probably a good idea.
But if it works out now like this, fair enough :)

Should we squash merge this?

Do you think we could make a new release?

Should we squash merge this?

My preference is always to squash on merge to main (or 0.x here) so that the history for main remains clean, while still have the PRs to see the full intermediary history of a given commit on main.

Do you think we could make a new release?

Done: https://github.com/cakephp/phinx/releases/tag/0.16.7