Trim trailing semicolon before executing query #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yopai
changed the title
Yopai
force-pushed
the
pdoadapter/2340-rm-trailing-semicolon
branch
from
b942cd5 to
6a043eb
Compare
(Currently writing an OCI Adapter) OCI doesn't allow a trailing semicolon. There can be a problem Still output the semicolon, so that output can be easily copy/pasted
…pter/2340-rm-trailing-semicolon
Yopai
force-pushed
the
pdoadapter/2340-rm-trailing-semicolon
branch
from
6a043eb to
e2c4d11
Compare
Yopai
changed the title
MasterOdin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2340
(Currently writing an OCI Adapter)
OCI doesn't allow a trailing semicolon.
Still output the semicolon, so that output can be easily copy/pasted