Skip to content

Conversation

@piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Dec 9, 2024

As in PR title

@dereuromark
Copy link
Member

why?

@MasterOdin MasterOdin merged commit 1b64777 into cakephp:0.x Dec 9, 2024
12 checks passed
@MasterOdin
Copy link
Member

MasterOdin commented Dec 9, 2024

Thanks for the contribution @piotr-cz.

@dereuromark Before this change, if using that example, then the line doing $this->pdo->setAttribute would result in a fatal error as $this->pdo had not yet been assigned (it was happening after). Now it'll work as expected. 😄

@dereuromark
Copy link
Member

Sry the diff looked differently for me so I saw it being accessed before Set.
Makes sense as in this pr 👍

@piotr-cz piotr-cz deleted the docs/fix-variable-order branch December 10, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants