Fix SQLiteAdapter::getColumns with Literal column #2331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
MasterOdin
commented
Dec 3, 2024
| $table = new Table('test', [], $this->adapter); | ||
| $columns = $table->getColumns(); | ||
| $this->assertCount(1, $columns); | ||
| $this->assertEquals(Literal::from('decimal'), array_pop($columns)->getType()); |
Member
Author
There was a problem hiding this comment.
DECIMAL is an accepted type, so ->getType() was returning "decimal", but since we were doing assertEquals, which equates to Literal::from('decimal') == 'decimal', the test was passing (as Literal was being converted to a string).
This is also why I added an assertion on the actual type of getType().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2330
PR fixes a bug where
SQLiteAdapter::getColumnswould throw an exception if the table had a column with aLiteraltype. This was due to a type error when passing the type ofSQLiteAdapter::parseDefaultValuewhich requires the type be a string. While I could have modifiedparseDefaultValueto accept astring|Literal, as the function is defined asprotected, this would have been a BC break, and so I went with converting the$type['name']to a string in the caller (getColumns) instead.