Run CI against PHP 8.4 #2321
Merged
Run CI against PHP 8.4 #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
dereuromark
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds PHP 8.4 to the CI test suite so that we can ensure compatibility there. I also removed testing against 8.2 and 8.3 as most likely if it works against PHP 8.1 and 8.4, then it'll work for the intermediate versions as well. The only exception is using PHP 8.2 as we test three discrete versions of mysql so we need three versions of PHP to differentiate them.
As part of this, I setup the code coverage stuff to run for all tested versions and only ignore the
prefer-lowestrun as there's code paths that only run for certain versions of mysql/postgres, and I didn't feel like keep changing those just to make codecov happy, and that uploading the coverage doesn't significantly slow down the CI that we shouldn't be doing it.