Skip to content

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Jul 22, 2025

Resolves #866

This currently does not include count for rollback when using phinx
So refs cakephp/phinx#2360
Maybe we can align this to have one final release together

@dereuromark dereuromark added this to the 4.x (CakePHP 5) milestone Jul 22, 2025
@dereuromark dereuromark changed the title 4.next migrate rollback count 4.next migrate/rollback count Jul 22, 2025
@dereuromark dereuromark marked this pull request as draft July 22, 2025 15:13
@dereuromark dereuromark requested a review from markstory July 22, 2025 19:03
@dereuromark dereuromark force-pushed the 4.next-migrate-rollback-count branch from 6fa1fcf to ae2527c Compare July 22, 2025 23:18
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@dereuromark dereuromark marked this pull request as ready for review August 3, 2025 11:35
@dereuromark
Copy link
Member Author

@markstory Added the guard clause.
Anything left?

I think we should do the 4.7.0 release then including this.
Then your major that removes all phinx dependencies and including necessary cleanup.

@dereuromark
Copy link
Member Author

I would squash merge to minimize issues with your other open PR now.

@markstory markstory merged commit 6e64e7d into 4.next Aug 4, 2025
13 checks passed
@markstory markstory deleted the 4.next-migrate-rollback-count branch August 4, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants