-
Notifications
You must be signed in to change notification settings - Fork 120
Fix up DateTime support for seed bulkinsert(). #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are a few tests for bulkinsert already, there could be a new test for bulkinsert with datetime values. Most of the tests we have for bulkinsert are in each driver implementation though.
You could include a seed integration test. There are a few integration tests for |
|
Hm its all super confusing as long as we didnt major and get rid of the overhead of two systems under the hood. So I assume this is part why for tests they dont run into the code above. I might need some help to get this covered. In real prod env the above fix works fine (using BaseSeed ext) and saves DateTime properly now. |
|
I removed the changes again, the tests still pass. |
|
Hah now I can reproduce also in CI :) |
d2d64da to
344f68f
Compare
|
@markstory Thanks a lot for the help I was finally able to get it reproduced for Mysql both locally and on CI, and was able to show now that the fix indeed is helping. |
|
The remaining error seems to be dependant on a fix in Phinx directly maybe? The rest seems now green instead of red :) |
|
All fixed, and the phinx one should be merged soon. PS: Lets please squash merge this one. |
25d4071 to
35eb3e0
Compare
|
@markstory |
It looks like there are still some issues with datetimes being cast to the wrong string format. This could be a migrations issue. There was a specialized |
12cd559 to
3879c9c
Compare
|
Thx, I think I finally got it. The remaining fail is already on 4.x and due to the fact that we support still cake5.0, and we probably need a version switch on those tests. |
I have to bump the dev dependency to not use 5.x-dev. |
Resolves #836
Apparently adding this to bulkinsert()
seems to fix it for my local MySql env.
How could a test case look like for this?
And in what class, for what method?