Inline doccomment above return #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now doesn't complain about inline docComment above return statement.
dereuromark
reviewed
Dec 12, 2017
| */ | ||
| function validFunctionReturnSeven() | ||
| { | ||
| /** @var Foo $foo */ |
Member
There was a problem hiding this comment.
Shouldnt we also fix that #172 issue that the inline doc blocks are fixed wrong in general? And that those are actually comments right now which they shouldnt be.
You can look into the existing sniffers I mentioned.
Member
Author
There was a problem hiding this comment.
That would require changing another sniff and beyond the scope of this PR.
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
============================================
+ Coverage 85.46% 85.52% +0.05%
- Complexity 290 293 +3
============================================
Files 23 23
Lines 812 815 +3
============================================
+ Hits 694 697 +3
Misses 118 118
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.