Skip to content

Conversation

@jorisvaesen
Copy link
Contributor

E_COMPILE_ERROR is an unrecoverable error and thus fatal. The error should be handled as such.

@jorisvaesen jorisvaesen changed the title (5.x) Mark E_COMPILE_ERROR as fatal error in handleShutdown (5.x) Mark E_COMPILE_ERROR as fatal error in ExceptionTrap::handleShutdown Dec 19, 2025
@dereuromark dereuromark added this to the 5.2.11 milestone Dec 19, 2025
@LordSimal
Copy link
Contributor

As we just discussed this in slack - here is an example which would cause this kind of error type:

<?php

register_shutdown_function(function() {
  var_dump(error_get_last());
});

interface Test {
    public function bla(): string;
}

class A implements Test {
    public function bla(): ?string {
        return null;
    }
}

@markstory markstory merged commit 453e5a4 into cakephp:5.x Dec 19, 2025
26 of 28 checks passed
@dereuromark
Copy link
Member

I am fairly certain

  1. Cake\Test\TestCase\Controller\Component\PaginatorComponentTest::testOutOfVeryBigPageNumberGetsClamped
    The float-string "3000000000000000000000000" is not representable as an int, cast occurred

Is actually a relevant fail in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants