Fix return type annotation for Validator::validate() #19126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validator::validate()is too restrictiveThe return type
array<string, array<string, string>>didn't account for nested validators. When usingaddNested()oraddNestedMany(), the error values can be nested arrays, not just strings.Example with nested validator:
Error structure when nested validation fails:
[ 'address' => [ 'street' => ['_required' => 'This field is required'], 'city' => ['_required' => 'This field is required'], ] ]The inner values are
array<string, string>, notstring.Fix: Updated return type to
array<string, array<string, string|array>>which accurately reflects the actual return structure when nested validators are used.