Skip to content

Fix setTimezone call on Date in RelativeTimeFormatter #19123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ADmad merged 1 commit into from
Dec 13, 2025
Merged

Fix setTimezone call on Date in RelativeTimeFormatter #19123

ADmad merged 1 commit into from
Dec 13, 2025

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Dec 13, 2025

Summary

Date does not have setTimezone() method, only DateTime does. This adds an instanceof check to prevent calling setTimezone on Date objects.

This matches the pattern already used in dateAgoInWords() method in the same class.

Fix

// Before
if ($options['timezone']) {
    $time = $time->setTimezone($options['timezone']);
}

// After
if ($time instanceof DateTime && $options['timezone']) {
    $time = $time->setTimezone($options['timezone']);
}

@dereuromark dereuromark added this to the 5.3.0 milestone Dec 13, 2025
@dereuromark
Fix setTimezone call on Date in RelativeTimeFormatter
4f3a19c 
Date does not have setTimezone() method, only DateTime does.
Add instanceof check to prevent calling setTimezone on Date objects.

This matches the pattern already used in dateAgoInWords().
@ADmad ADmad merged commit c78c927 into 5.x Dec 13, 2025
15 checks passed
@ADmad ADmad deleted the 5.x-setTimezone-fix branch December 13, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

defect

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dereuromark @ADmad