Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Sep 25, 2025

No description provided.

@ADmad ADmad added this to the 5.2.9 milestone Sep 25, 2025
@ADmad ADmad marked this pull request as draft September 25, 2025 08:06
@ADmad ADmad force-pushed the phpunit-ci branch 4 times, most recently from 6bc7d94 to 723e5d3 Compare September 25, 2025 09:15
$this->assertTrue(true);
});
}
// public function testTriggerWarningLevelDisabled(): void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test generates:

1) /home/runner/work/cakephp/cakephp/src/Core/functions.php:315
This was a mistake.

Triggered by:

* Cake\Test\TestCase\Core\FunctionsGlobalTest::testTriggerWarningLevelDisabled
  /home/runner/work/cakephp/cakephp/tests/TestCase/Core/FunctionsGlobalTest.php:335

Not sure how to fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now took care of this by not failing phpunit for warnings from the globalfunctions testsuite.

@ADmad ADmad force-pushed the phpunit-ci branch 2 times, most recently from 6e6bc86 to 3985154 Compare September 25, 2025 09:18
@ADmad ADmad force-pushed the phpunit-ci branch 2 times, most recently from dfa6aa3 to 7606bcd Compare September 25, 2025 13:19
Not sure how to deal with the FunctionsGlobalTest::testTriggerWarningEnabled() test
@ADmad ADmad marked this pull request as ready for review September 25, 2025 14:37
@ADmad ADmad merged commit 50d106c into 5.x Sep 28, 2025
14 of 15 checks passed
@ADmad ADmad deleted the phpunit-ci branch September 28, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants