How to re-run those CI/CD checks?

As coding standard did fail to fetch phpstan binary 👀

cc @rochamarcelo

Looks good.

@kolorafa you could use the existing TSubject (https://github.com/cakephp/cakephp/pull/18925/files#diff-1ab7f7c61167076737415b6cbabb97d5d6a0e70e5adec87dc763135f8a1117b1L47)

@rochamarcelo You mean like changing
@return \Cake\Datasource\ResultSetInterface<array-key, mixed>
into
@return \Cake\Datasource\ResultSetInterface<array-key, TSubject>
?

@kolorafa yes, also for \Cake\Datasource\EntityInterface|array

Sorry for the delay.

Thinking if I should change
\Cake\ORM\ResultSetFactory<\Cake\Datasource\EntityInterface|array>

into
\Cake\ORM\ResultSetFactory<TSubject>
or
\Cake\ORM\ResultSetFactory<TSubject|array>

the same for
`\Cake\Datasource\ResultSetInterface<array-key, \Cake\Datasource\EntityInterface|mixed>

into
\Cake\Datasource\ResultSetInterface<array-key, TSubject>
or
\Cake\Datasource\ResultSetInterface<array-key, TSubject|mixed>

because in theory ResultSetInterface could contain any type/structure if formatters created and returing god-knowns-what $result = $formatter($result, $this); in line 747

Error: Parameter #1 $entity of method Cake\ORM\Table<array>::delete() expects Cake\Datasource\EntityInterface, array|Cake\Datasource\EntityInterface given.
Error: Parameter #1 $entity of method Cake\ORM\Table<array>::delete() expects Cake\Datasource\EntityInterface, array|Cake\Datasource\EntityInterface given.
Error: Parameter #1 $entity of method Cake\ORM\Table<array>::delete() expects Cake\Datasource\EntityInterface, array|Cake\Datasource\EntityInterface given.
Error: Property Cake\ORM\Query\SelectQuery<TSubject of array|Cake\Datasource\EntityInterface>::$resultSetFactory (Cake\ORM\ResultSetFactory<TSubject of array|Cake\Datasource\EntityInterface>) does not accept Cake\ORM\ResultSetFactory<array|Cake\Datasource\EntityInterface>.

The issue is because we allow "array" as a TSubject

* @template TSubject of \Cake\Datasource\EntityInterface|array
introduced in 2023-01-03

places that would need change/assert to allow arrays as a return values:

Question, should I remove allowing array as a returned type, or update the code to assert/check if the deleted value is actually EntityInterface and throw CakeException if it's not?

Or better revert/skip last changes and skip them for now, as it might be better to introduce this change not in patch release but minor release?

Ignore TSubject for now since it is causing more issues. Maybe we can use it in the future.

Froce-pushed branch without the last commit.

I would also like those changes to be introduced, but I agree that it does generate issues that should be introduced in patch release.

So this PR only fixes the bad/missing second template for typehinting issue, and should be ready to merge.
Failing tests doesn't sound to be related to changes.

Rebased :)

@ADmad Does this look good to you?

@dereuromark If the IDEs and phpstan and are happy I am happy :)