Skip to content

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Aug 23, 2025

Resolves #18844

This ensures consistent permissions across the framework, matching what the Filesystem class uses by default (0755). The Filesystem class already creates files with standard permissions, so now both directories and files
will have consistent, standard permissions instead of the more permissive 0770 for directories.

@dereuromark dereuromark added this to the 5.2.7 milestone Aug 23, 2025
@LordSimal
Copy link
Contributor

I'd personally use 775 since e.g. shared hostings don't provide a separate PHP process per user/vhost which runs as that user. They usually have 1 group which all vhost users and the PHP-FPM pool belong to.

Therefore currently anything not running as that exact user won't have write access to those files/folders.

@dereuromark
Copy link
Member Author

This is only making it consistent with the other commands/values.
If we want a different approach, we would need to tackle the other occurrences too.

@dereuromark
Copy link
Member Author

I wonder if this should be configurable or some kind of constant then.

@markstory
Copy link
Member

I wonder if this should be configurable or some kind of constant then.

We could add a Configure value for default permissions, and default it to use 777 ^ umask(). That would enable both folks who can control their runtime and those who can't. This may create some more cross package dependencies though.

@markstory markstory merged commit 13ec215 into 5.x Aug 24, 2025
12 of 13 checks passed
@markstory markstory deleted the bugfix/file-folder-permissions branch August 24, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I18nExtractCommand and permissions

3 participants