Fix up rector found issues. #18832
Merged
Fix up rector found issues. #18832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Aug 17, 2025
ADmad
approved these changes
Aug 18, 2025
Member
ADmad
left a comment
ADmad
left a comment
There was a problem hiding this comment.
A phpcs error related to line length needs to be addressed.
nicosp
pushed a commit
to QoboLtd/cakephp
that referenced
this pull request
Aug 18, 2025
* Fix up rector found issues. * Fix up as per review. * Fix CS.
dereuromark
added a commit
that referenced
this pull request
Aug 23, 2025
* Fix up rector found issues. * Fix up as per review. * Fix CS.
arshidkv12
pushed a commit
to arshidkv12/cakephp
that referenced
this pull request
Sep 6, 2025
* Fix up rector found issues. * Fix up as per review. * Fix CS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed 5.next is dirty on CI right now.
This is what rector wants us to fix up.