Fix PHP 8.5 deprecations: replace SplObjectStorage::contains() and remove ReflectionProperty::setAccessible() #18831

arshidkv12 · 2025-08-16T16:04:04Z

Replaced all occurrences of SplObjectStorage::contains() with offsetExists() to fix deprecation warnings.
Removed ReflectionProperty::setAccessible() calls in Debugger.php as they have no effect in PHP 8.5.

…move ReflectionProperty::setAccessible()

LordSimal · 2025-08-16T18:43:45Z

Thanks for the PR. As you can see certain dependencies of cakephp are not PPH 8.5 ready yet, therefore the CI won't get green until those dependencies release a new version, which support PHP 8.5. A PR for that lib is already present, but it will take time till it gets through and released.

Especially the removal of setAccessible seems weird to me since this was needed in the past to access property states from an object even though they those props are not public (and no getter is present).
Guess we could also fix this by using anonymous classes and adding a getter.

I have not checked the PHP Doc related to those deprecations yet, but could you link to those deprecations? 😁 Makes it easier for us to validate what is being done here.

arshidkv12 · 2025-08-16T18:46:22Z

Please check it https://php.watch/versions/8.5/releases/8.5.0beta1

arshidkv12 · 2025-08-16T18:49:10Z

dereuromark · 2025-08-17T23:45:35Z

I also dont understand how setAccessable can be safely removed, when we also support older PHP versions (8.1+).
But it seems to not fail for those..
Apparently, rector also does it now for us, included in #18832
Fair enough.

arshidkv12 · 2025-08-18T00:27:35Z

The laminas/laminas-diactoros package requires PHP 8.1 or higher, so versions below 8.1 are not supported.

dereuromark · 2025-08-18T00:30:10Z

Read my comment again :) it was always about 8.1+ but <8.5

ADmad · 2025-08-18T03:58:53Z

I also dont understand how setAccessable can be safely removed, when we also support older PHP versions (8.1+).

It can be removed because the method is a no-op. Non public methods and properties can be accessed through reflection objects without having to explicitly make them accessible since PHP 8.1

markstory · 2025-08-18T04:40:54Z

Thanks for putting this together. I think we'll need to wait to merge it until some of our upstream dependencies are ready as I don't want to leave CI broken for that long.

dereuromark · 2025-08-18T11:33:15Z

That said: We could already merge in the code changes (without CI changes) in a separate PR though, to have it released as "PHP 8.5" compatible code in the next 5.x release.

ADmad · 2025-08-19T08:21:32Z

I have updated the workflow config so that the testsuite runs on PHP 8.5.

@arshidkv12 There are few more deprecations and other warnings which need to be addressed.

arshidkv12 · 2025-08-19T08:29:05Z

I have updated the workflow config so that the testsuite runs on PHP 8.5.

@arshidkv12 There are few more deprecations and other warnings which need to be addressed.

Let me check and get back to you.

othercorey · 2025-08-19T08:58:58Z

src/Routing/Middleware/AssetMiddleware.php

-            ->withHeader('Date', gmdate(DATE_RFC7231, time()))
-            ->withHeader('Last-Modified', gmdate(DATE_RFC7231, $modified))
-            ->withHeader('Expires', gmdate(DATE_RFC7231, $expire));
+            ->withHeader('Date', gmdate('D, d M Y H:i:s \G\M\T', time()))


I don't like replacing a constant with a hand-crafted format everywhere. If this truly no longer exists in PHP, should we consider adding it?

You’re right.

Maybe something that can be added to chronos?

It seems PHP will remove all DATE_* constants so the best idea would be to define them ourselves.

@dereuromark this reminds me of the removed time related constants we had in core.

Only SUNFUNCS_* constants are deprecated.

php/doc-en#4006

That makes more sense

OK, so the scope is a bit smaller:

The DATE_RFC7231 and DateTimeInterface::RFC7231 constants have been deprecated.

For these headers

->withHeader('Last-Modified', ...)

etc, wouldnt it make more sense to use another future proof PHP constant and maybe also one that is more "ISO", those are headers after all, not some local datetime output.

$response = $response->withHeader('Date', (new DateTime('now', new DateTimeZone('UTC'))) ->format(DateTimeInterface::ATOM));

or is that not valid? and it has to be a non machine readable one?

Thanks for the suggestion!

For HTTP headers like Date and Last-Modified, the officially recommended format is RFC 7231 / RFC 1123, which is always in GMT (D, d M Y H:i:s GMT). While DateTimeInterface::ATOM is ISO 8601 and machine-readable, strict HTTP compliance expects the RFC format. We could define a constant or helper to make it future-proof and easier to reuse, while keeping it compliant with HTTP standards.

Then I am confused why PHP would drop RFC constants..^^ Sometimes you gotto wonder.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Last-Modified

arshidkv12 · 2025-08-19T09:15:36Z

Fix XML-related warnings #18834

config/bootstrap.php

ADmad

The split packages phpstan failure will be fixed after next release.

src/Core/functions.php

dereuromark · 2025-08-19T16:25:55Z

Careful
PHPStan has this annoying behavior that it doesnt properly work across PHP versions.

$uri = $metadata['uri'];

This might fail for you locally, but for our CI we need the "old way" - you basically ignore the issue locally.

arshidkv12 · 2025-08-19T16:37:12Z

Careful PHPStan has this annoying behavior that it doesnt properly work across PHP versions.

$uri = $metadata['uri'];

This might fail for you locally, but for our CI we need the "old way" - you basically ignore the issue locally.

Ok

ADmad · 2025-08-19T17:22:23Z

Please undo all the changes after the phpcs empty line fix, as I already stated earlier the split package phpstan fails will be automatically resolved after the next release (as the split packages repos are only updated when a release is made).

Arshid and others added 3 commits August 16, 2025 21:32

Fix PHP 8.5 deprecations: replace SplObjectStorage::contains() and re…

8934f66

…move ReflectionProperty::setAccessible()

Update Debugger.php

af1d147

Update ci.yml

c4641e9

Temporarily ignore PHP version constraint for 8.5

9401809

Remove curl_close() call as it has no effect in PHP 8.0+

86f004e

LordSimal mentioned this pull request Aug 19, 2025

add PHP 8.5 to CI #18821

Closed

Replace DATE_RFC7231

988744f

othercorey reviewed Aug 19, 2025

View reviewed changes

Arshid added 2 commits August 19, 2025 14:40

Define DATE_RFC7231

401ae5e

Define DATE_RFC7231

70d8363

Arshid added 2 commits August 19, 2025 14:54

Define DATE_RFC7231

7255571

CAKE_DATE_RFC7231

d3670c6

dereuromark added this to the 5.2.7 milestone Aug 19, 2025

dereuromark added the deprecations label Aug 19, 2025

ADmad reviewed Aug 19, 2025

View reviewed changes

config/bootstrap.php Outdated Show resolved Hide resolved

Arshid added 3 commits August 19, 2025 17:56

CAKE_DATE_RFC7231

d9d8586

CAKE_DATE_RFC7231

c3e547f

CAKE_DATE_RFC7231

d385948

ADmad approved these changes Aug 19, 2025

View reviewed changes

ADmad reviewed Aug 19, 2025

View reviewed changes

src/Core/functions.php Outdated Show resolved Hide resolved

CAKE_DATE_RFC7231

a06adc8

dereuromark added the needs squashing The pull request should be squashed before merging label Aug 19, 2025

Arshid added 2 commits August 19, 2025 21:07

fix the he split packages phpstan failure

19dbbe3

fix the split packages phpstan failure

435d610

Undo

4998a33

ADmad merged commit 76efc9f into cakephp:5.x Aug 23, 2025
12 of 14 checks passed

Fix PHP 8.5 deprecations: replace SplObjectStorage::contains() and remove ReflectionProperty::setAccessible() #18831

Fix PHP 8.5 deprecations: replace SplObjectStorage::contains() and remove ReflectionProperty::setAccessible() #18831

Uh oh!

Conversation

arshidkv12 commented Aug 16, 2025

Uh oh!

LordSimal commented Aug 16, 2025

Uh oh!

arshidkv12 commented Aug 16, 2025

Uh oh!

arshidkv12 commented Aug 16, 2025

Uh oh!

dereuromark commented Aug 17, 2025

Uh oh!

arshidkv12 commented Aug 18, 2025

Uh oh!

dereuromark commented Aug 18, 2025

Uh oh!

ADmad commented Aug 18, 2025

Uh oh!

markstory commented Aug 18, 2025

Uh oh!

dereuromark commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ADmad commented Aug 19, 2025

Uh oh!

arshidkv12 commented Aug 19, 2025

Uh oh!

othercorey Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

arshidkv12 Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

LordSimal Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garas Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

dereuromark Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

dereuromark Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

dereuromark Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arshidkv12 Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dereuromark Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

arshidkv12 Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

arshidkv12 commented Aug 19, 2025

Uh oh!

Uh oh!

ADmad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dereuromark commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arshidkv12 commented Aug 19, 2025

Uh oh!

ADmad commented Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

dereuromark commented Aug 18, 2025 •

edited

Loading

LordSimal Aug 19, 2025 •

edited

Loading

dereuromark Aug 19, 2025 •

edited

Loading

arshidkv12 Aug 19, 2025 •

edited

Loading

dereuromark commented Aug 19, 2025 •

edited

Loading