Skip to content

Conversation

@dereuromark
Copy link
Member

I am really curious how in all those years this wasnt found earlier :)

Resolves #18823

@markstory
Copy link
Member

I am really curious how in all those years this wasnt found earlier :)

Using getEnv() to read http headers is likely an uncommon scenario as we have dedicated methods for reading headers.

@tunnela
Copy link

tunnela commented Aug 12, 2025

@markstory true, however, it's used in the ServerRequest::clientIp()... Anyway, this looks good to me @dereuromark!

@markstory markstory merged commit 71c8fe8 into 5.x Aug 13, 2025
13 checks passed
@markstory markstory deleted the fix-getenv-array-handling branch August 13, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headers stored as arrays in $_environment cause getEnv() to return "Array"

3 participants