Skip to content

Fix for invisible validation issue. #18321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markstory merged 5 commits into from
Aug 18, 2025
Merged

Fix for invisible validation issue. #18321

markstory merged 5 commits into from
Aug 18, 2025

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Apr 11, 2025 •
edited
Loading

Is this a valid test case for the scenario in #18241 ?
It does not show any error messages that we can display the user in the form or give back via flash message.
But I think somehow we should be able to do that, otherwise domain rule validation is even less useful compared to normal validation.

@dereuromark dereuromark added this to the 5.2.2 milestone Apr 11, 2025
@dereuromark dereuromark requested a review from markstory April 17, 2025 22:58
@markstory markstory modified the milestones: 5.2.2, 5.2.3, 5.2.4 Apr 18, 2025
@markstory markstory modified the milestones: 5.2.4, 5.2.5 May 17, 2025
@LordSimal LordSimal marked this pull request as draft May 30, 2025 13:31
@LordSimal
Copy link
Contributor

LordSimal commented May 30, 2025

I converted it to a draft so it can't be mistakenly merged

@markstory markstory modified the milestones: 5.2.5, 5.2.6 Jun 21, 2025
@dereuromark
Copy link
Member Author

dereuromark commented Jun 27, 2025

I didnt get any feedback on this since April.
How can we proceed here, is the general consensus that we want to fix this for 5.next?

markstory
markstory reviewed Jun 28, 2025
View reviewed changes
@markstory markstory modified the milestones: 5.2.6, 5.2.7 Aug 2, 2025
@dereuromark
Copy link
Member Author

dereuromark commented Aug 8, 2025

Looks like sth else is now failing:

There was 1 failure:

  1. Cake\Test\TestCase\ORM\RulesCheckerIntegrationTest::testCustomErrorMessageFromRuleNoErrorField
    Failed asserting that an array is empty.

@dereuromark dereuromark added defect and removed bug labels Aug 10, 2025
@dereuromark dereuromark changed the title Add a test case for invisible validation issue. Fix for invisible validation issue. Aug 10, 2025
@dereuromark
Copy link
Member Author

dereuromark commented Aug 10, 2025

@markstory I adjusted the test case.

@dereuromark dereuromark marked this pull request as ready for review August 10, 2025 02:01
ADmad
ADmad reviewed Aug 10, 2025
View reviewed changes
@dereuromark dereuromark mentioned this pull request Aug 13, 2025
Closed
@dereuromark dereuromark requested a review from markstory August 13, 2025 22:41
@markstory markstory merged commit 68b3bd6 into 5.x Aug 18, 2025
11 checks passed
@markstory markstory deleted the 5.x-validation-assoc-buildrules branch August 18, 2025 16:28
@dereuromark dereuromark mentioned this pull request Aug 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADmad ADmad ADmad approved these changes

@markstory markstory Awaiting requested review from markstory

Assignees

No one assigned

Labels

defect

Projects

None yet

Milestone

5.2.7

Development

Successfully merging this pull request may close these issues.

5 participants

@dereuromark @LordSimal @markstory @ADmad