Revert "Fix up behavior callbacks for clean inheritance and consisten… #12002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy." This reverts commit 9e93097. Changing argument typehints is not backwards compatible and causes errors when these methods are overridden in extending classes.
dereuromark
approved these changes
Apr 25, 2018
Member
dereuromark
left a comment
dereuromark
left a comment
There was a problem hiding this comment.
4.0 then.
A bummer that at the time no one saw this..
Thx for doing this.
Member
Author
|
The change still already exists in |
Member
|
... And 4.x migration guide then gets completed this time. |
Codecov Report
@@ Coverage Diff @@
## master #12002 +/- ##
============================================
+ Coverage 91.94% 91.94% +<.01%
Complexity 13505 13505
============================================
Files 467 467
Lines 34718 34718
============================================
+ Hits 31921 31923 +2
+ Misses 2797 2795 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cy."
This reverts commit 9e93097.
Changing argument hints is not backwards compatible and causes error when these
methods are overridden in extending classes.