Fix Request::referer(true) returning scheme-relative URLs #11503
Conversation
| $result = $request->referer(true); | ||
| $this->assertSame('/some/path', $result); | ||
|
|
||
| $request->env('HTTP_REFERER', Configure::read('App.fullBaseUrl') . '///cakephp.org/'); |
There was a problem hiding this comment.
Whats the value here?
I would expect a test string like //my-domain/path as test to test the above code change.
There was a problem hiding this comment.
Sorry if I am wrong, but the problem is at line 578 in ServerRequest.php:
$ref = substr($ref, strlen($base));This removes App.fullBaseUrl (e.g. http://localhost) and ServerRequest::$webroot (e.g. /) from the HTTP_REFERER. So I tested http://localhost + / + //cakephp.org/ here.
Codecov Report
@@ Coverage Diff @@
## master #11503 +/- ##
=========================================
Coverage 93.38% 93.38%
- Complexity 13016 13017 +1
=========================================
Files 436 436
Lines 32753 32753
=========================================
Hits 30586 30586
Misses 2167 2167
Continue to review full report at Codecov.
|
4 participants
No description provided.