Fix map() resetting cached object allowing build() to use the updated object #11457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is there a way we could capture the changed behavior with a test case? |
Codecov Report
@@ Coverage Diff @@
## master #11457 +/- ##
============================================
+ Coverage 93.11% 93.12% +0.01%
- Complexity 13008 13012 +4
============================================
Files 436 436
Lines 33699 33708 +9
============================================
+ Hits 31378 31392 +14
+ Misses 2321 2316 -5
Continue to review full report at Codecov.
|
Member
Author
|
I added some tests, and cleaned up the smell about the inline class in the process :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map() does not reset internal object cache for this key, and there is no way to tell build() to make a fresh one.
As Travis around dereuromark/cakephp-ide-helper@f3128fe shows, mapping a different type after building has already been done still uses the old object.
Using set() and an actual instance (
Type::set('uuid', new UuidType());) works, but I think resetting here is the expected and intuitive behavior after remapping.With this fix
Type::map('uuid', UuidType::class);etc works.