Skip to content

Conversation

@markstory
Copy link
Member

The generation and validation sides of Digest authentication were using different algorithms which results in broken digest authentication.

Refs #11103

The generation and validation sides of Digest authentication were using
different algorithms which results in broken digest authentication.

Refs #11103
@markstory markstory added this to the 3.5.7 milestone Nov 22, 2017
@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #11453 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11453      +/-   ##
============================================
+ Coverage     93.11%   93.14%   +0.03%     
- Complexity    13008    13383     +375     
============================================
  Files           436      436              
  Lines         33699    34465     +766     
============================================
+ Hits          31378    32103     +725     
- Misses         2321     2362      +41
Impacted Files Coverage Δ Complexity Δ
src/Auth/DigestAuthenticate.php 91.76% <100%> (+0.19%) 32 <0> (ø) ⬇️
src/Http/Response.php 93.6% <0%> (-0.1%) 500% <0%> (+242%)
src/ORM/Association/Loader/SelectLoader.php 99.6% <0%> (+0.15%) 103% <0%> (+41%) ⬆️
src/ORM/Marshaller.php 97.23% <0%> (+0.25%) 217% <0%> (+67%) ⬆️
src/ORM/Association/BelongsToMany.php 99.38% <0%> (+0.58%) 167% <0%> (ø) ⬇️
src/Cache/Engine/FileEngine.php 90.16% <0%> (+1.09%) 73% <0%> (ø) ⬇️
src/Network/Socket.php 72.22% <0%> (+1.18%) 73% <0%> (+15%) ⬆️
src/Cache/Engine/NullEngine.php 27.27% <0%> (+2.27%) 22% <0%> (+10%) ⬆️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️
src/Cache/CacheEngine.php 93.61% <0%> (+4.25%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d42b5f...dcd7382. Read the comment docs.

@lorenzo lorenzo merged commit 03f0a08 into master Nov 23, 2017
@lorenzo lorenzo deleted the digest-nonce branch November 23, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants