More phpstan related fixes. #11451
Merged
More phpstan related fixes. #11451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Nov 21, 2017
| * | ||
| * @param \Cake\Datasource\RepositoryInterface|null $table The default table object to use | ||
| * @return \Cake\Datasource\RepositoryInterface|$this | ||
| * @param \Cake\Datasource\RepositoryInterface|\Cake\ORM\Table|null $table The default table object to use |
Member
There was a problem hiding this comment.
The param is type hinted as RepositoryInterface and Table implements that interface, so why is explicitly specifying Table necessary?
Member
Author
There was a problem hiding this comment.
Because it is used in other places with the concrete one (code smell that cant be fixed until the next major).
PS: The IDE shows this also as yellow (mismatch in type).
Codecov Report
@@ Coverage Diff @@
## master #11451 +/- ##
============================================
- Coverage 93.12% 93.12% -0.01%
Complexity 13008 13008
============================================
Files 436 436
Lines 33697 33699 +2
============================================
+ Hits 31380 31381 +1
- Misses 2317 2318 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPSTAN level 3
=>
:-)
We should also start inline deprecations for specific (and really bad) default values like bool where in future API it will actually have to be null (as per strict php7.1+).
This way people can already be a bit more aware and maybe adjust already the code to reflect this.