Bug in CakeEmail matching pattern #11222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We should have a test case with such an example domain to prevent regressions. We probably also need to port this to 3.x then. |
3 tasks
Contributor
|
can this be merged? |
Member
|
I mentioned above that a test case is critical for this to be mergable. |
Contributor
|
ok. sorry. we are doing the test case now |
dereuromark
approved these changes
Sep 22, 2017
Author
|
Not sure why the tests failed but it seems that it's not caused by my changes. |
Member
|
Yes, unrelated. I re-triggered it. |
|
Are underscores actually allowed in domain names? |
Member
|
I'll get this merged and ported to 3.x |
markstory
added a commit
that referenced
this pull request
Sep 23, 2017
Port changes from #11222 to 3.x. Subdomains and internal DNS allow _ to be used.
o0h
pushed a commit
to o0h/cakephp
that referenced
this pull request
Nov 16, 2017
Port changes from cakephp#11222 to 3.x. Subdomains and internal DNS allow _ to be used.
o0h
pushed a commit
to o0h/cakephp
that referenced
this pull request
Dec 30, 2017
Port changes from cakephp#11222 to 3.x. Subdomains and internal DNS allow _ to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.