False positive URL validation (Test case only) #11211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with Kibana urls for instance
This matches the rules defined in RFC 3986 Section 3.5
Codecov Report
@@ Coverage Diff @@
## master #11211 +/- ##
============================================
- Coverage 93.14% 93.13% -0.02%
- Complexity 12981 12984 +3
============================================
Files 437 437
Lines 33626 33641 +15
============================================
+ Hits 31321 31331 +10
- Misses 2305 2310 +5
Continue to review full report at Codecov.
|
Contributor
Author
|
Thank you for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with Kibana urls for instance
Kibana urls such as this one are not valid whereas they seem to be valid regarding the specs (valid in an
input type=urlfor instance). The failure seems to be related to the presence of the trailing?_g=()part.The sample url in this failing test can be found from the "Share" tab of a dashboard in the latest Kibana version.
The PR only contains the failing test case for now, I will try to look at the regex and update the PR if nobody beats me to it!