phpstan is unhappy https://travis-ci.org/cakephp/cakephp/jobs/276148218#L836

What is it talking about?

Problem is due to line 76 $this->commands = $this->getCommands();. getCommands() returns an array and you can use getIterator() on an array. So the code needs to account for the fact that $this->commands can be an array or \Cake\Console\CommandCollection instance. Also the typehint of $commands property needs to be updated.

Also there is currently no test coverage for line 76 or the getCommands() method.

Codecov Report

Merging #11203 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master   #11203      +/-   ##
============================================
+ Coverage     93.14%   93.15%   +<.01%     
  Complexity    12981    12981              
============================================
  Files           437      437              
  Lines         33623    33626       +3     
============================================
+ Hits          31318    31324       +6     
+ Misses         2305     2302       -3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ef39...a931060. Read the comment docs.

how about now, phpstan seems happy.