Better document unsafe inputs in the QueryBuilder. #11176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better document which methods are not safe for untrusted data. Refs #11148
Codecov Report
@@ Coverage Diff @@
## master #11176 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 12978 12978
=========================================
Files 437 437
Lines 33619 33619
=========================================
Hits 31317 31317
Misses 2302 2302
Continue to review full report at Codecov.
|
saeideng
reviewed
Sep 13, 2017
| * This method allows you to set complex expressions | ||
| * as order conditions unlike order() | ||
| * | ||
| * Order fields are not suitable for use with user supplied data as they are |
Member
There was a problem hiding this comment.
plain text or text in note box(warning,..) for these notes?
Member
There was a problem hiding this comment.
Is it possible to make a box here?
Member
Author
There was a problem hiding this comment.
I don't think so unless we start embedding HTML in docblocks.
Member
There was a problem hiding this comment.
oh, I forgot this repo is for core not docs ,i'm sorry :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better document which methods are not safe for untrusted data.
Refs #11148