Skip to content

Add RWX build provider#4836

Merged
devlead merged 1 commit into
cake-build:developfrom
robinaugh:jason/add-rwx-build-provider
May 21, 2026
Merged

Add RWX build provider#4836
devlead merged 1 commit into
cake-build:developfrom
robinaugh:jason/add-rwx-build-provider

Conversation

@robinaugh

Copy link
Copy Markdown
Contributor

Following https://github.com/orgs/cake-build/discussions/4796, this PR adds RWX as a build provider.

I have already been in contact with @devlead via email and we've set up a Cake organization on RWX. A sample run can be seen here: https://cloud.rwx.com/mint/cake/runs/a8eb7be0436248508544a2c0fda9df08

  • The sample run requires a login (Mattias and the Cake team have access), but runs triggered from this public repository (on main/develop/hotfix* branches) will be publicly accessible and linked from the badge in the README.
  • More documentation on how RWX permissions work with Open Source can be found here.

@robinaugh

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="RWX"

@devlead devlead force-pushed the jason/add-rwx-build-provider branch from 59cab62 to 7742642 Compare May 20, 2026 14:51

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM 👍 , just a few questions.

Comment thread .rwx/cake.yml Outdated
Comment thread .rwx/cake.yml Outdated
Comment thread src/Cake.Common/Build/Rwx/Data/RwxEnvironmentInfo.cs
@robinaugh robinaugh force-pushed the jason/add-rwx-build-provider branch 2 times, most recently from 29a66b3 to 8521060 Compare May 20, 2026 21:16
@devlead devlead force-pushed the jason/add-rwx-build-provider branch from 8521060 to 84d919b Compare May 20, 2026 21:55
Comment thread tests/integration/Cake.Common/Build/Rwx/RwxProvider.cake
Comment thread src/Cake.Common/Build/Rwx/Commands/RwxCommands.cs
@robinaugh robinaugh force-pushed the jason/add-rwx-build-provider branch from 84d919b to 56264ad Compare May 21, 2026 18:38
@robinaugh robinaugh requested a review from devlead May 21, 2026 18:45
Adds Cake.Common.Build.Rwx alongside the 14 existing build providers,
exposing IsRunningOnRwx and BuildSystem.Rwx.Environment.{Run,Task,Actor}
populated from the documented RWX env var contract
(https://www.rwx.com/docs/environment-variables). Detection is via the
RWX env var; RWX does not currently expose a PR identifier so this
provider does not contribute to BuildSystem.IsPullRequest.
@devlead devlead force-pushed the jason/add-rwx-build-provider branch from 56264ad to 91ce98b Compare May 21, 2026 18:58

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead enabled auto-merge May 21, 2026 19:21
@devlead devlead merged commit f200042 into cake-build:develop May 21, 2026
17 of 18 checks passed
@devlead

devlead commented May 21, 2026

Copy link
Copy Markdown
Member

@robinaugh your changes have been merged. Thanks for your contribution and for addressing all feedback 👍

This was referenced May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RWX as a build provider

2 participants