GH2666: Fix GetFiles/GetDirectories/GetPaths when brace expansion is the only path segment#4774
Merged
Merged
Conversation
devlead
commented
Mar 16, 2026
devlead
commented
Member
- In GlobVisitor, run FindCandidates for any non-identifier path segment so patterns like "Dir/{package.json}" or "Dir/{a,b,c}" are matched instead of skipped
- Extend GlobberFixture.UnixLike with /Working/Project and sample files for brace-expansion-only-segment tests
- Update existing globber tests that match under /Working to include the new fixture paths and counts
- Add unit tests for single and multiple alternatives when brace expansion is the only segment
- Add integration tests for GetFiles, GetDirectories, and GetPaths with brace-expansion-only-segment patterns
- fixes GetFiles() using Glob curly braces gives empty result #2666
…xpansion is the only path segment
- In GlobVisitor, run FindCandidates for any non-identifier path segment so patterns like "Dir/{package.json}" or "Dir/{a,b,c}" are matched instead of skipped
- Extend GlobberFixture.UnixLike with /Working/Project and sample files for brace-expansion-only-segment tests
- Update existing globber tests that match under /Working to include the new fixture paths and counts
- Add unit tests for single and multiple alternatives when brace expansion is the only segment
- Add integration tests for GetFiles, GetDirectories, and GetPaths with brace-expansion-only-segment patterns
- fixes cake-build#2666
Member
|
@devlead thanks for getting this added! |
This was referenced May 22, 2026
This was referenced May 25, 2026
This was referenced Jun 15, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.