GH4658: Add support for MSBuild 18 and VS2026.#4659
Merged
devlead merged 1 commit intocake-build:developfrom Dec 5, 2025
peymanr34:feature/msbuild-18
Merged
GH4658: Add support for MSBuild 18 and VS2026.#4659devlead merged 1 commit intocake-build:developfrom peymanr34:feature/msbuild-18
devlead merged 1 commit intocake-build:developfrom
peymanr34:feature/msbuild-18
Conversation
Contributor
Author
|
Should this PR also include adding "18" to
Adding it seems fine and doesn't require changes to the test runners since they're using |
|
This looks good, would be great to get this merged and released. |
|
I agree. Would be nice to be able to update builders to the new BuildTools. |
Member
|
@peymanr34 your changes have been merged, thanks for your contribution 👍 |
Contributor
Author
|
@devlead Thanks very much. |
|
Just checking in, is there any chance we could get a release with this change? Is there anything I can do to help test/validate? |
This was referenced Mar 1, 2026
This was referenced Mar 2, 2026
This was referenced Mar 2, 2026
This was referenced Mar 16, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here, there are some differences between VS2022 and VS2026:
C:\Program Files\Microsoft Visual Studio\18\Insiders\C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\amd64\MSBuild.exeC:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\MSBuild\Current\Bin\amd64\MSBuild.exeNotes:
VisualStudio.GetYearAndEditionRootPathmethod can be renamed to avoid confusion.VisualStudio.Editions.Previewcan be split between VS2022 and VS2026 but it feels unnecessary.This PR is loosely based on: #3465