Skip to content

GH4642: Standardize execution status display in report printers#4644

Merged
devlead merged 1 commit intocake-build:developfrom
devlead:feature/gh-4642
Nov 2, 2025
Merged

GH4642: Standardize execution status display in report printers#4644
devlead merged 1 commit intocake-build:developfrom
devlead:feature/gh-4642

Conversation

@devlead
Copy link
Copy Markdown
Member

@devlead devlead commented Oct 31, 2025

Standardize execution status display in report printers

  • Introduce ToReportStatus() extension method to standardize execution status display across both report printers, ensuring consistent formatting ("Succeded", "Skipped", "Failed") instead of using enum ToString() directly.
  • Add null argument validation to CakeSpectreReportPrinter and CakeReportPrinter constructors for improved defensive programming.
  • Update CakeSpectreReportPrinter and CakeReportPrinter to use the new extension method for status formatting.
  • Add test coverage for both printers including verbosity-based output verification.
  • fixes Display Delegated/Executed status as Succeded in Cake task summary #4642

@devlead devlead requested a review from a team October 31, 2025 14:10
Copy link
Copy Markdown
Contributor

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succeeded contains double 'c' and double 'e'

…inters

- Introduce ToReportStatus() extension method to standardize execution status display across both report printers, ensuring consistent formatting ("Succeeded", "Skipped", "Failed") instead of using enum ToString() directly.
- Add null argument validation to CakeSpectreReportPrinter and CakeReportPrinter constructors for improved defensive programming.
- Update CakeSpectreReportPrinter and CakeReportPrinter to use the new extension method for status formatting.
- Add test coverage for both printers including verbosity-based output verification.
- fixes cake-build#4642

- Fix typo

Co-authored-by: Jericho <[email protected]>
Copy link
Copy Markdown
Member

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devlead devlead enabled auto-merge November 2, 2025 09:33
@devlead devlead merged commit 53894dc into cake-build:develop Nov 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display Delegated/Executed status as Succeded in Cake task summary

3 participants