Adds two missing parameters for SignTool#4406
Merged
devlead merged 2 commits intocake-build:developfrom Jan 2, 2025
Merged
Conversation
\csp - Cryptographic Service Provider \kc - Private Key Container Name
devlead
requested changes
Dec 5, 2024
Member
devlead
left a comment
devlead
left a comment
There was a problem hiding this comment.
LGTM, could you please add som tests in
Moved the new parameters to be just before the target assemblies.
Contributor
Author
|
I have added the tests for the two new parameters. I also moved the two new parameters to just before the target assemblies. That way they are at the end of all the parameters that were already there. |
Marusyk
approved these changes
Dec 7, 2024
Member
|
@tstewart65 your changes have been merged, thanks for your contribution 👍 |
This was referenced Oct 5, 2025
This was referenced Nov 12, 2025
This was referenced Nov 24, 2025
This was referenced Dec 11, 2025
This was referenced Jan 19, 2026
This was referenced Mar 2, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\csp - Cryptographic Service Provider
\kc - Private Key Container Name
Fix for #4404