Skip to content

GH4331/GH4349: Migrate GHA Artifact to V4 API#4350

Merged
devlead merged 2 commits intocake-build:developfrom
devlead:feature/gh-4349/gh-4331
Oct 4, 2024
Merged

GH4331/GH4349: Migrate GHA Artifact to V4 API#4350
devlead merged 2 commits intocake-build:developfrom
devlead:feature/gh-4349/gh-4331

Conversation

@devlead
Copy link
Copy Markdown
Member

@devlead devlead commented Sep 30, 2024

@devlead devlead force-pushed the feature/gh-4349/gh-4331 branch from 3f195e8 to 88493f4 Compare September 30, 2024 20:17
@devlead devlead marked this pull request as ready for review September 30, 2024 20:44
@devlead devlead requested a review from a team September 30, 2024 20:45
@devlead
Copy link
Copy Markdown
Member Author

devlead commented Sep 30, 2024

@cake-build/cake-team this should be ready for review, integration tests no longer cause warnings like this
image
Example previous run: https://github.com/cake-build/cake/actions/runs/11092875166

Upload / Download artifact is completely rewritten for the new v4 APIs but public Cake Common APIs/Aliases remain the same and integration tests look to generate same set of artifacts

Previous: https://github.com/cake-build/cake/actions/runs/11092875166#artifacts
Now: https://github.com/cake-build/cake/actions/runs/11113486680?pr=4350#artifacts

The sizes are now correct previously it reported the uncompressed size, and uploads are noticeably faster.

@devlead devlead force-pushed the feature/gh-4349/gh-4331 branch from 88493f4 to 40a9311 Compare October 4, 2024 07:38
@devlead devlead force-pushed the feature/gh-4349/gh-4331 branch from 40a9311 to 2a6260f Compare October 4, 2024 07:39
@devlead devlead requested a review from gep13 October 4, 2024 10:53
@devlead devlead enabled auto-merge October 4, 2024 11:42
gep13
gep13 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devlead devlead merged commit 86ad011 into cake-build:develop Oct 4, 2024
@gep13
Copy link
Copy Markdown
Member

gep13 commented Oct 4, 2024

@devlead thank you for getting this done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gep13 gep13 gep13 approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHubActionCommand DownloadArtifact is not using the latest @v4 Version GitHubActionCommand UploadArtifact is not using the latest @v4 Version.

2 participants

@devlead @gep13